From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 16/18] Remove init_raw_breakpoint_without_location
Date: Tue, 3 May 2022 20:26:59 +0100 [thread overview]
Message-ID: <f7c43622-97f1-d565-232c-47d14f3cda35@palves.net> (raw)
In-Reply-To: <20220502221553.1394743-17-tom@tromey.com>
On 2022-05-02 23:15, Tom Tromey wrote:
> --- a/gdb/break-catch-fork.c
> +++ b/gdb/break-catch-fork.c
> @@ -34,8 +34,9 @@
>
> struct fork_catchpoint : public breakpoint
> {
> - explicit fork_catchpoint (bool is_vfork_)
> - : is_vfork (is_vfork_)
> + explicit fork_catchpoint (struct gdbarch *gdbarch, bool is_vfork_)
> + : breakpoint (gdbarch, bp_catchpoint),
> + is_vfork (is_vfork_)
> {
> }
This one could drop the "explicit" too. (You did that to other types.)
next prev parent reply other threads:[~2022-05-03 19:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 22:15 [PATCH 00/18] Minor breakpoint cleanups Tom Tromey
2022-05-02 22:15 ` [PATCH 01/18] Change print_recreate_thread to a method Tom Tromey
2022-05-02 22:15 ` [PATCH 02/18] Remove breakpoint::ops Tom Tromey
2022-05-02 22:15 ` [PATCH 03/18] Boolify breakpoint::explains_signal Tom Tromey
2022-05-02 22:15 ` [PATCH 04/18] Move works_in_software_mode to watchpoint Tom Tromey
2022-05-02 22:15 ` [PATCH 05/18] Constify breakpoint::print_it Tom Tromey
2022-05-02 22:15 ` [PATCH 06/18] Constify breakpoint::print_one Tom Tromey
2022-05-02 22:15 ` [PATCH 07/18] Constify breakpoint::print_mention Tom Tromey
2022-05-02 22:15 ` [PATCH 08/18] Constify breakpoint::print_recreate Tom Tromey
2022-05-02 22:15 ` [PATCH 09/18] Remove unnecessary line from catch_exec_command_1 Tom Tromey
2022-05-02 22:15 ` [PATCH 10/18] Add constructor to fork_catchpoint Tom Tromey
2022-05-02 22:15 ` [PATCH 11/18] Add constructor to solib_catchpoint Tom Tromey
2022-05-02 22:15 ` [PATCH 12/18] Add constructor to signal_catchpoint Tom Tromey
2022-05-02 22:15 ` [PATCH 13/18] Add constructor to syscall_catchpoint Tom Tromey
2022-05-02 22:15 ` [PATCH 14/18] Add constructor to exception_catchpoint Tom Tromey
2022-05-02 22:15 ` [PATCH 15/18] Disable copying for breakpoint Tom Tromey
2022-05-02 22:15 ` [PATCH 16/18] Remove init_raw_breakpoint_without_location Tom Tromey
2022-05-03 19:26 ` Pedro Alves [this message]
2022-05-03 22:43 ` Tom Tromey
2022-05-02 22:15 ` [PATCH 17/18] Add initializers to tracepoint Tom Tromey
2022-05-02 22:15 ` [PATCH 18/18] Introduce catchpoint class Tom Tromey
2022-05-03 19:32 ` Pedro Alves
2022-05-03 23:02 ` Tom Tromey
2022-05-04 11:37 ` Pedro Alves
2022-05-07 2:19 ` Simon Marchi
2022-05-07 16:07 ` Tom Tromey
2022-05-07 19:31 ` Simon Marchi
2022-05-16 18:22 ` Tom Tromey
2022-05-16 19:29 ` Simon Marchi
2022-05-03 19:33 ` [PATCH 00/18] Minor breakpoint cleanups Pedro Alves
2022-05-06 18:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7c43622-97f1-d565-232c-47d14f3cda35@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).