From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2CE783858C50 for ; Fri, 10 Feb 2023 02:18:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CE783858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9F9831E110; Thu, 9 Feb 2023 21:18:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675995521; bh=KI6YilfvIUU4QAUptQ54k6r7APWrLDFi7CFwxF9vyks=; h=Date:Subject:To:References:From:In-Reply-To:From; b=exbU98pt3sN59Yz7lF5z2jMq0Le/9ZigmibYOLyYMz8wMgFcmW6WU3avLGuJFXwJE PMXBYzPOHY2eu3m8MWmx169QkI3pyNCUy7hxqEr0uwazk1IoQDImfBbxaf3j0OrinP JmxEMM7GEETewGxlFlEgKkWVVG8d+hOewzt6v5uM= Message-ID: Date: Thu, 9 Feb 2023 21:18:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 29/47] Turn value_contents_eq into a method Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230209-submit-value-fixups-2023-v1-0-55dc2794dbb9@tromey.com> <20230209-submit-value-fixups-2023-v1-29-55dc2794dbb9@tromey.com> From: Simon Marchi In-Reply-To: <20230209-submit-value-fixups-2023-v1-29-55dc2794dbb9@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gdb/value.h b/gdb/value.h > index e3574b3a169..2253784aedb 100644 > --- a/gdb/value.h > +++ b/gdb/value.h > @@ -396,6 +396,66 @@ struct value > it. */ > void fetch_lazy (); > > + /* Compare LENGTH bytes of VAL1's contents starting at OFFSET1 with > + LENGTH bytes of VAL2's contents starting at OFFSET2. The comments should be tweaked since VAL1 doesn't exist anymore. Simon