public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/python] Fix gdb.python/py-disasm.exp on arm-linux
Date: Mon, 10 Jun 2024 15:31:41 +0200	[thread overview]
Message-ID: <f7e9131c-a23b-4bc5-9169-1ec446dd8893@suse.de> (raw)
In-Reply-To: <87frtolon7.fsf@tromey.com>

On 6/7/24 18:10, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> Indeed L means "long long", but K means "unsigned long long".
> 
> Tom> -					       "KL", len, offset));
> Tom> +					       "IL", len, offset));
>   
> This patch is ok but, I think, incomplete.
> 
> offset has type LONGEST, which is int64_t -- not necessarily "long long".

Thanks for the review.

I've fixed this by using gdb_py_longest, and submitted a v2 here ( 
https://sourceware.org/pipermail/gdb-patches/2024-June/209808.html ).

The v2 is now a series, which also contains a fix for the 
!HAVE_LONG_LONG scenario.

Thanks,
- Tom


      parent reply	other threads:[~2024-06-10 13:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-07  6:29 Tom de Vries
2024-06-09 16:58 ` Alexandra Petlanova Hajkova
     [not found] ` <87frtolon7.fsf@tromey.com>
2024-06-10 13:31   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7e9131c-a23b-4bc5-9169-1ec446dd8893@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).