From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 9B25F385840F for ; Mon, 10 Jun 2024 13:31:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B25F385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B25F385840F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718026269; cv=none; b=uQqUDdI6HGkq/q/FcgyfP2Tum/XGSydeLQNHnCQmuyKD0xYnPZq1yQzS1NuMFVVzehidyZZQNCfJ+649plSLFwjwQAwCxe9Lv7S0GF+xrkVCYMHulWYD0PMjT6XJSZ+tEDL92wJvbGFN80uhdylq7LZv3Y4mWXZPkJsG3S5N3lI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718026269; c=relaxed/simple; bh=7ejxMZ96CdVt4niob0sOpXm51s7Ax/+uE3Mb2xptCxo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=EWMsGNJQw4VQMF/ctweykS97OIu8b7uFNZI+KHUfnhDXisjMVj1C46kxGOUNG9aXF6JQPjqFhQBwhpyuXzEVo8o8W+zi1kuzmdKgA72qiOosBR483gRpNWM6zMKtQUdjlw5ULvUAUN6IBApRqh8vufaoNmfBwIJQg0Ukq+PdTDM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9B2651F7F3; Mon, 10 Jun 2024 13:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718026266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqqCBFGhGJbTIkaTa5A+oEsIZV9fcI7jtEFefC7rHMQ=; b=k5GEmZZQ1ZVXRjLh7gGNWLCDn5Dbcnc/lDY0/nlHxYpQ9XCSp6g+CYIWD9QixIUEn0sX3G F6ANGKvN2S+0UnlF8WoZ2I7DGGqVUaU59RYLw3vOIIhFG1rrNDEo/gCvEgVFqfesf6tBz2 dBrV4oTuHp4FR04uKtjFr6HasT/Adp4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718026266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqqCBFGhGJbTIkaTa5A+oEsIZV9fcI7jtEFefC7rHMQ=; b=0lHBRb6Mdji9vCSm6vjiqxhMNLhaw6aobcMrK4hiQIzPV8zdmUGB2ldozcX6VNz3Uev+0Z mRhIaOPm97GtKWAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718026266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqqCBFGhGJbTIkaTa5A+oEsIZV9fcI7jtEFefC7rHMQ=; b=k5GEmZZQ1ZVXRjLh7gGNWLCDn5Dbcnc/lDY0/nlHxYpQ9XCSp6g+CYIWD9QixIUEn0sX3G F6ANGKvN2S+0UnlF8WoZ2I7DGGqVUaU59RYLw3vOIIhFG1rrNDEo/gCvEgVFqfesf6tBz2 dBrV4oTuHp4FR04uKtjFr6HasT/Adp4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718026266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UqqCBFGhGJbTIkaTa5A+oEsIZV9fcI7jtEFefC7rHMQ=; b=0lHBRb6Mdji9vCSm6vjiqxhMNLhaw6aobcMrK4hiQIzPV8zdmUGB2ldozcX6VNz3Uev+0Z mRhIaOPm97GtKWAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7F88113A51; Mon, 10 Jun 2024 13:31:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +zSYHRoAZ2YoNQAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 13:31:06 +0000 Message-ID: Date: Mon, 10 Jun 2024 15:31:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/python] Fix gdb.python/py-disasm.exp on arm-linux To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240607062934.5941-1-tdevries@suse.de> <87frtolon7.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87frtolon7.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spamd-Result: default: False [-3.97 / 50.00]; BAYES_HAM(-2.68)[98.62%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,suse.de:email,imap1.dmz-prg2.suse.org:helo] X-Spam-Score: -3.97 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/7/24 18:10, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Indeed L means "long long", but K means "unsigned long long". > > Tom> - "KL", len, offset)); > Tom> + "IL", len, offset)); > > This patch is ok but, I think, incomplete. > > offset has type LONGEST, which is int64_t -- not necessarily "long long". Thanks for the review. I've fixed this by using gdb_py_longest, and submitted a v2 here ( https://sourceware.org/pipermail/gdb-patches/2024-June/209808.html ). The v2 is now a series, which also contains a fix for the !HAVE_LONG_LONG scenario. Thanks, - Tom