From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8F6183858D1E for ; Tue, 19 Apr 2022 03:37:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F6183858D1E Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 23J3bgX7005311 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Apr 2022 23:37:47 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 23J3bgX7005311 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1346A1E787; Mon, 18 Apr 2022 23:37:42 -0400 (EDT) Message-ID: Date: Mon, 18 Apr 2022 23:37:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3] gdb: fix using clear command to delete non-user breakpoints(PR cli/7161) Content-Language: en-US To: Enze Li , tom@tromey.com Cc: gdb-patches@sourceware.org References: <87sfqez4de.fsf@tromey.com> <6affe6c7-cf0f-0c3d-8271-65d6f8a3aba6@polymtl.ca> From: Simon Marchi In-Reply-To: <6affe6c7-cf0f-0c3d-8271-65d6f8a3aba6@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 19 Apr 2022 03:37:42 +0000 X-Spam-Status: No, score=-3034.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2022 03:37:53 -0000 On 2022-04-18 19:49, Simon Marchi via Gdb-patches wrote: > > > On 2022-04-15 23:42, Enze Li via Gdb-patches wrote: >> The clear command shouldn't delete momentary and internal breakpoints, >> nor internal breakpoints created via Python's gdb.Breakpoint. >> >> This patch fixes this issue and adds a testcase. >> >> Regression tested on x86_64 openSUSE Tumbleweed(VERSION_ID="20220413"). >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=7161 > > Hi, > > I see this test failing on Ubuntu 20.04: > > 65 maint info break -1^M > 66 Num Type Disp Enb Address What^M > 67 -1 shlib events keep n 0x00007ffff7fd2fd1 inf 1^M > 68 -1.1 y 0x00007ffff7fd2fd1 inf 1^M > 69 (gdb) maint info break -1^M > 70 Num Type Disp Enb Address What^M > 71 -1 shlib events keep n 0x00007ffff7fd2fd1 inf 1^M > 72 -1.1 y 0x00007ffff7fd2fd1 inf 1^M > 73 (gdb) FAIL: gdb.base/clear_non_user_bp.exp: maint info breakpoint -1 error > > Simon Sorry for the noise, I didn't see that Tom had already reported that failure. Simon