Re: [PATCH v3 16/17] Simplify dwarf_expr_context class interface

[Simon Marchi <simon.marchi@polymtl.ca>]

> diff --git a/gdb/dwarf2/expr.h b/gdb/dwarf2/expr.h
> index c2138b31d79..f3985a7ecce 100644
> --- a/gdb/dwarf2/expr.h
> +++ b/gdb/dwarf2/expr.h
> @@ -119,45 +119,49 @@ struct dwarf_stack_value
>     its current state and its callbacks.  */
>  struct dwarf_expr_context
>  {
> -  dwarf_expr_context (dwarf2_per_objfile *per_objfile);
> +  dwarf_expr_context (struct dwarf2_per_objfile *per_objfile,
> +		      int addr_size);
>    virtual ~dwarf_expr_context () = default;
>  
>    void push_address (CORE_ADDR value, bool in_stack_memory);
> -  void eval (const gdb_byte *addr, size_t len);
>  
> -  /* Fetch the result of the expression evaluation in a form of
> -     a struct value, where TYPE, SUBOBJ_TYPE and SUBOBJ_OFFSET
> -     describe the source level representation of that result.  */
> -  struct value *fetch_result (struct type *type = nullptr,
> -			      struct type *subobj_type = nullptr,
> -			      LONGEST subobj_offset = 0);
> +  /* Evaluate the expression at ADDR (LEN bytes long) in a given PER_CU
> +     and FRAME context.  TYPE, SUBOBJ_TYPE and SUBOBJ_OFFSET describe
> +     the expected struct value representation of the evaluation
> +     result. The ADDR_INFO property can be specified to override the

Two spaces after period.

Simon