From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: <guitton@adacore.com>
Subject: Re: [PATCH] define_command: Don't convert command name to lower case
Date: Mon, 24 Jul 2017 21:54:00 -0000 [thread overview]
Message-ID: <f84b2460-df75-9da2-638b-76d903169962@ericsson.com> (raw)
In-Reply-To: <1500932879-11652-1-git-send-email-simon.marchi@ericsson.com>
On 2017-07-24 11:47 PM, Simon Marchi wrote:
> I think this won't be too controversial, so I went ahead and made a patch for
> it.
>
> Commit
>
> Command names: make them case sensitive
> 3d7b173c29900879c9a5958dd6029fd36666e57c
>
> made command name lookup case sensitive. However, define_command, used
> when creating a user-defined command, converts the command name to
> lowercase, assuming that the command name lookup works in a case
> insensitive way. This causes user-defined commands with capital letters
> in their name to only be callable with a lowercase version:
>
> (gdb) define Foo
> Type commands for definition of "Foo".
> End with a line saying just "end".
> >print 1
> >end
> (gdb) Foo
> Undefined command: "Foo". Try "help".
> (gdb) foo
> $1 = 1
>
> This patch removes that conversion to lowercase, so that the user can
> call the command with the same name they provided.
I forgot to mention but this would be a candidate for the 8.0 branch as well,
since it's a regression.
Simon
next prev parent reply other threads:[~2017-07-24 21:54 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 14:25 [RFA] candidates for ambiguous command in upper case Jerome Guitton
2017-01-10 15:07 ` Yao Qi
2017-01-10 15:19 ` Jerome Guitton
2017-01-10 15:28 ` Simon Marchi
2017-01-10 15:40 ` Jerome Guitton
2017-01-10 17:00 ` Pedro Alves
2017-01-11 15:37 ` Jerome Guitton
2017-01-11 17:26 ` Yao Qi
2017-01-11 17:35 ` Luis Machado
2017-01-11 20:24 ` Pedro Alves
2017-01-12 10:18 ` Jerome Guitton
2017-01-12 16:37 ` Pedro Alves
2017-01-16 16:32 ` Jerome Guitton
2017-01-17 1:58 ` Pedro Alves
2017-01-17 16:29 ` Luis Machado
2017-01-17 16:35 ` Pedro Alves
2017-01-17 16:51 ` Luis Machado
2017-01-17 17:04 ` Pedro Alves
2017-01-17 17:13 ` Luis Machado
2017-01-31 14:39 ` Jerome Guitton
2017-01-31 15:20 ` Pedro Alves
2017-02-08 18:05 ` Jerome Guitton
2017-07-24 21:17 ` Simon Marchi
2017-07-24 21:48 ` [PATCH] define_command: Don't convert command name to lower case Simon Marchi
2017-07-24 21:54 ` Simon Marchi [this message]
2017-08-28 21:20 ` Simon Marchi
2017-07-26 12:42 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f84b2460-df75-9da2-638b-76d903169962@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).