From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E870C3858D28 for ; Thu, 3 Nov 2022 12:58:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E870C3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667480339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W003b3+HnW8y4Ym1uDbsR5vWJ2zsIIKQCKbYV/yZ2Mk=; b=D1KxRzY7y1rw9eFSUTrUPSFTBBKZhda6yF6NqP6MTKFM77jFyuANXqwwYo8Y0doHAHg6G0 3r5CxeS/PeHJQ/p31Lv4Q/f5yKPxCAZMPn8ojS8E3S1ZP9VznUl6bu/oajxZviCVWJAbd8 gNB3Jh9QT7laDy8disGXnmjMTOrah5Y= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-387-SPjhHTN7NzSBmbOWKogswA-1; Thu, 03 Nov 2022 08:58:58 -0400 X-MC-Unique: SPjhHTN7NzSBmbOWKogswA-1 Received: by mail-wm1-f71.google.com with SMTP id i128-20020a1c3b86000000b003cf4ff1b917so826888wma.2 for ; Thu, 03 Nov 2022 05:58:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W003b3+HnW8y4Ym1uDbsR5vWJ2zsIIKQCKbYV/yZ2Mk=; b=k87TCFOVJhKSPAM+AbD+xjfLTIOu4vdSjavRMR/Zm4DNCR05Z6BY/A+1TqGR0sE44u A9jK7uLcnFuwrCvDDa+CYI9stsM3ZrEWYU8Q7TlonV+h8hF/UYd7nvtmrvmX+B07s48O OBnZ/7eMWoS1hZCDx7AmgqPxgjoXrQVPfJGn5/tPOaApIuVjDCXkVpUsouv+gx655pL/ 0WACSx4xNCOCoR+wl1DAXdLs0jjt60U5BQxhKy4QBGf/mlQVYimA8mcxomTz8Zunvi76 8A+XkyDyBy01JwFjOCmJqxpRvkQJDy1l8oSv46ecy2/7/H7HAYlUmRnFruZ5C/o6aJHa KntQ== X-Gm-Message-State: ACrzQf20MEbrpNjtwUm9qE6A9TcrI6P1iWJIpn0yfSM8mN0SBnQpgfUL Vx3kb+z50VLgQtyar47Py3LRNA//G1MEoizGIObtatF80OQ8z4QAnagQDD5wifVMDD7JvRE0YG/ hgGEMrOryoHkdes64FZgJcw== X-Received: by 2002:adf:f911:0:b0:21e:c0f6:fd26 with SMTP id b17-20020adff911000000b0021ec0f6fd26mr18471472wrr.361.1667480336759; Thu, 03 Nov 2022 05:58:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7PnZiQWgQhJOiixTrqeJLc/71gGuKPRmpLMiWtinSjAYXsXZy6adxABIcS2Tqz9llnCCQrwg== X-Received: by 2002:adf:f911:0:b0:21e:c0f6:fd26 with SMTP id b17-20020adff911000000b0021ec0f6fd26mr18471454wrr.361.1667480336511; Thu, 03 Nov 2022 05:58:56 -0700 (PDT) Received: from [10.202.9.92] (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id e7-20020a05600c448700b003c64c186206sm1136671wmo.16.2022.11.03.05.58.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 05:58:56 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 13:58:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3] gdb: Fix issue with Clang CLI macros To: Simon Marchi , gdb-patches@sourceware.org References: <20221018132215.2593111-1-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02/11/2022 13:36, Simon Marchi wrote: >> +# Clang has this bug where it puts the macros defined on the command-line >> +# after the main file portion (see PR 29034) and: > I'm not sure if the "and" a the end is supposed to be there or not, it > reads weird. Oops, it was supposed to be inside the parenthesis, making it (see PR 29034 and https://github.com/llvm/llvm-project/issues/54506) Is it fine if I keep it like that? Cheers, Bruno > Simon >