Re: [PATCH 1/2] gdb/python doc: Add register_unwinder to code example

[Paulo Neves <ptsneves@gmail.com>]

Hello all,

Any idea when this can be merged or if there anything missing?

Paulo Neves

On 5/28/22 14:20, Eli Zaretskii wrote:
>> Date: Sat, 28 May 2022 13:55:08 +0200
>> From: Paulo Neves via Gdb-patches <gdb-patches@sourceware.org>
>> Cc: Paulo Neves <ptsneves@gmail.com>
>>
>> It is now clear in the example code that an unwinder needs to be
>> registered to be used.
>> ---
>>   gdb/doc/python.texi | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
>> index cb5283e03c0..5b7fba798a9 100644
>> --- a/gdb/doc/python.texi
>> +++ b/gdb/doc/python.texi
>> @@ -2814,6 +2814,8 @@ class MyUnwinder(Unwinder):
>>           # Return the result:
>>           return unwind_info
>>   
>> +# To use an unwinder it needs to be registered and enabled.
>> +gdb.unwinder.register_unwinder (<locus>, MyUnwinder, replace=<True|False>)
>>   @end smallexample
> Thanks, I think this needs to be reviewed by someone who knows how to
> program the Python unwinders.  As far as Texinfo is concerned, this is
> fine.