From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 481BB3858C56 for ; Tue, 21 Jun 2022 11:17:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 481BB3858C56 Received: by mail-lj1-x235.google.com with SMTP id d19so15012982lji.10 for ; Tue, 21 Jun 2022 04:17:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dDomsimYKlfdU5dT3dmZhEY7rdBKG8fwXSsvm325rl4=; b=bJ4zXaXFQKIE881F9a9jgguEDlrcs2x6ZQ/oKfnFbNxh9uRCHDzcq6r9u7qTJyX4fq jMSMtioW5UUxMH7fbQ/UsmTbnIpAcS3UUeqqfPMTdXQkKspG+CuLCADPlqAZxvW/4Kra 0/vHs9SKdwOzpSibdOp8by/T3fasUQEZ44s9YAiU8DOazK1X/dXKNbWS/8dBzfGhJaJB ZE8rx2fJ1eWEYlTrGQXtMoUjNRx1SwDSDtUPPYQ9iDlYCafx5TQ0uDdzlmSY1foViS3q 29uNHI3iMLF/2TTWR1DK99hDHhgjvXwJm6trplXKRX5svwRu4fD3o8h82t4v6pxSLf6y IMCQ== X-Gm-Message-State: AJIora/9xSQh46cHiLSCppScaBMw9fMoOovT03L402qHGk945V4zZUVh c2+jA+sXFixuCntqXv/wJWkPP8QMzg== X-Google-Smtp-Source: AGRyM1sfkKm+Z++womv9oDrQNfBVjiAAKPyoIpK5yBQAomkgJhQG0/NNVqf749kAcHwqAh3N389ppg== X-Received: by 2002:a2e:93c8:0:b0:24d:b348:b070 with SMTP id p8-20020a2e93c8000000b0024db348b070mr14152595ljh.434.1655810253750; Tue, 21 Jun 2022 04:17:33 -0700 (PDT) Received: from [192.168.1.10] (83.11.57.73.ipv4.supernova.orange.pl. [83.11.57.73]) by smtp.gmail.com with ESMTPSA id s18-20020a056512215200b00477c1172063sm2131723lfr.165.2022.06.21.04.17.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jun 2022 04:17:33 -0700 (PDT) Message-ID: Date: Tue, 21 Jun 2022 13:17:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/2] gdb/python doc: Add register_unwinder to code example Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20220528115509.3865342-1-ptsneves@gmail.com> <20220528115509.3865342-2-ptsneves@gmail.com> <83tu99luft.fsf@gnu.org> From: Paulo Neves In-Reply-To: <83tu99luft.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 11:17:38 -0000 Hello all, Any idea when this can be merged or if there anything missing? Paulo Neves On 5/28/22 14:20, Eli Zaretskii wrote: >> Date: Sat, 28 May 2022 13:55:08 +0200 >> From: Paulo Neves via Gdb-patches >> Cc: Paulo Neves >> >> It is now clear in the example code that an unwinder needs to be >> registered to be used. >> --- >> gdb/doc/python.texi | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi >> index cb5283e03c0..5b7fba798a9 100644 >> --- a/gdb/doc/python.texi >> +++ b/gdb/doc/python.texi >> @@ -2814,6 +2814,8 @@ class MyUnwinder(Unwinder): >> # Return the result: >> return unwind_info >> >> +# To use an unwinder it needs to be registered and enabled. >> +gdb.unwinder.register_unwinder (, MyUnwinder, replace=) >> @end smallexample > Thanks, I think this needs to be reviewed by someone who knows how to > program the Python unwinders. As far as Texinfo is concerned, this is > fine.