From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EE009385B1AC for ; Thu, 1 Dec 2022 16:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE009385B1AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 613271E0D3; Thu, 1 Dec 2022 11:44:58 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669913098; bh=auVQo7ITW4JsyF/LbC2QH5++KdNVo8XpExd1PTsKemg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rd5Dk9CZ6smaCJZ9NJNr/espSJqm6vFLF4A6vGD56kel/XiwpJOQiYIXI0kn7ENFg TiMRjhkooyBlzHlG/uVHmDjUbCqi6Uzq5lGE0uyC+gJPwfLIM+o6Ao0SzXSZzcm+ew Tv61FyqH0fXewjV1czkgMwzpJjNmpflsMzUbJsIc= Message-ID: Date: Thu, 1 Dec 2022 11:44:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] gdb/dwarf: add some QUIT macros Content-Language: fr To: Kevin Buettner , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20221201160144.1045410-1-simon.marchi@efficios.com> <20221201092742.70e5e920@f35-zws-nvidia> From: Simon Marchi In-Reply-To: <20221201092742.70e5e920@f35-zws-nvidia> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/1/22 11:27, Kevin Buettner via Gdb-patches wrote: > On Thu, 1 Dec 2022 11:01:44 -0500 > Simon Marchi via Gdb-patches wrote: > >> While testing the fix for PR 29105, I noticed I couldn't ctrl-C my way >> out of GDB expanding many symtabs. GDB was busy in a loop in >> cooked_index_functions::expand_symtabs_matching. Add a QUIT there. I >> also happened to see a spot in >> cooked_index_functions::expand_matching_symbols where a QUIT would be >> useful too, since we iterate over a potentially big number of index >> entries and expand CUs in the loop. Add one there too. > > LGTM. > > Kevin > Thanks, pushed! Simon