From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id 1D5C8384E79B for ; Mon, 12 Dec 2022 20:20:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D5C8384E79B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id ja17so3658928wmb.3 for ; Mon, 12 Dec 2022 12:20:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:subject:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ApIa/gB8aUBhE2L/p7b29q4fN9Vu4jvwfIRIcLPe580=; b=QPKA8RosOBqb4h5/0JtDGkCaU3Hc208trSC+xNhvZ2Lc7pECO9QEyfiXzaEhcLVOqn cBv5AS/+0B/UXL+dFyOjDbQnIt7ZqS2SbPzjHgSbk4vTMFiBc+GAO0PJx1VcyMVvxa4R wXePSPWL32BQ9DOt2oLvw7k280AXcd5vuA38l1A/uBRhWpKYWb4I01OM9p95u2ffxTf3 u0CiHLfX0rt3xb0x/3GvdtIFV5bSrdpX6xuMK+tJFYcmLJroPu+U7w9y4ZQf6qZVAbyP bC04KAFjF+oc/MASPiqwM4/STDqrXpor8IVNDhBb0MuIbynXeH5Aw65TD11o6Mm0eScC 5RsA== X-Gm-Message-State: ANoB5plL6hywXiCYUMlUcDNTIOT3kjWhoMhsfnQ5EFXlLBftKoFEbOqd KILyddnrwaY4rseGWXHPjrk3u1dCfU70Eg== X-Google-Smtp-Source: AA0mqf7IaFCc00jRxh7iom1zcoBJnqqbbPZ7hPZoT0BHYvsGsHWw8Bbd/TKaN2Glb4zHrI02xivosA== X-Received: by 2002:a05:600c:4f05:b0:3cf:85af:6a4a with SMTP id l5-20020a05600c4f0500b003cf85af6a4amr17124525wmq.25.1670876403917; Mon, 12 Dec 2022 12:20:03 -0800 (PST) Received: from ?IPv6:2001:8a0:f912:6700:afd9:8b6d:223f:6170? ([2001:8a0:f912:6700:afd9:8b6d:223f:6170]) by smtp.gmail.com with ESMTPSA id i2-20020a1c5402000000b003c6c182bef9sm12676144wmb.36.2022.12.12.12.20.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 12:20:03 -0800 (PST) From: Pedro Alves Subject: Re: [PATCH v2 00/29] Step over thread clone and thread exit To: Tom de Vries , gdb-patches@sourceware.org References: <20220713222433.374898-1-pedro@palves.net> Message-ID: Date: Mon, 12 Dec 2022 20:20:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-10-03 7:37 p.m., Tom de Vries wrote: > On 10/3/22 15:46, Tom de Vries wrote: >> On 7/14/22 00:24, Pedro Alves wrote: >>> Tested on x86-64 Ubuntu 20.04, native and gdbserver. >>> >> >> FYI, I applied on the base commit, and tried to build (with --enable-targets=all), and ran into: >> ... >> /home/vries/gdb_versions/devel/src/gdb/rs6000-tdep.c:1097:64: error: no matching function for call to ‘displaced_step_buffers::finish(gdbarch*&, thread_info*&, gdb_signal&)’ >>     return per_inferior->disp_step_buf->finish (arch, thread, sig); >>                                                                  ^ >> ... >> and: >> ... >> /home/vries/gdb_versions/devel/src/gdb/rs6000-tdep.c:8353:72: error: invalid conversion from ‘displaced_step_finish_status (*)(gdbarch*, thread_info*, gdb_signal)’ to ‘displaced_step_finish_status (*)(gdbarch*, thread_info*, const target_waitstatus&)’ [-fpermissive] >>     set_gdbarch_displaced_step_finish (gdbarch, ppc_displaced_step_finish); >>                                                                          ^ >> ... >> >> I'll try again without --enable-targets=all. > > That went ok, so I did a testsuite run, using taskset -c 0 (which for me triggers PR24845). > > So, PR24845 is gone with this series, which is great. > > I'm though running into: > ... > FAIL: gdb.threads/stepi-over-clone.exp: continue > FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: stepi > FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: $thread_count == 2 >   ... > ... > > The first FAIL looks like: > ... > (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch syscall clone > continue^M > Continuing.^M > ^M > Catchpoint 2 (call to syscall clone), clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:78^M > 78      ../sysdeps/unix/sysv/linux/x86_64/clone.S: No such file or directory.^M > (gdb) FAIL: gdb.threads/stepi-over-clone.exp: continue > ... > and AFAICT the corresponding check is: > ... > gdb_test "continue" \ >     "Catchpoint $decimal \\(call to syscall clone\\), $hex in clone \\(\\)" > ... > so, that looks like some kind to debuginfo difference to me: I don't have glibc-debuginfo installed, but I guess the static library contains some debug info. Thanks. I've tweaked the testcase to be more permissive. > > So, AFAICT, nothing serious. Agreed.