From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146461-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14374 invoked by alias); 9 Apr 2018 17:23:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14364 invoked by uid 89); 9 Apr 2018 17:23:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: smtp.polymtl.ca
Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 17:23:55 +0000
Received: from simark.ca (simark.ca [158.69.221.121])	(authenticated bits=0)	by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w39HNmu3032202	(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT)	for <gdb-patches@sourceware.org>; Mon, 9 Apr 2018 13:23:53 -0400
Received: by simark.ca (Postfix, from userid 112)	id 6CC5D1EF60; Mon,  9 Apr 2018 13:23:48 -0400 (EDT)
Received: from simark.ca (localhost [127.0.0.1])	by simark.ca (Postfix) with ESMTP id D787B1E47D;	Mon,  9 Apr 2018 13:23:45 -0400 (EDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Mon, 09 Apr 2018 17:23:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 2/5] Copy string_view files from libstdc++
In-Reply-To: <e45d06b8-c460-993b-4642-20cc6387d802@redhat.com>
References: <20180407132629.3787-1-simon.marchi@polymtl.ca> <20180407132629.3787-2-simon.marchi@polymtl.ca> <e45d06b8-c460-993b-4642-20cc6387d802@redhat.com>
Message-ID: <f9402203d6de3ed1ce034a45593649ad@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.3.4
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon,  9 Apr 2018 17:23:48 +0000
X-IsSubscribed: yes
X-SW-Source: 2018-04/txt/msg00153.txt.bz2

On 2018-04-09 09:44, Pedro Alves wrote:
> On 04/07/2018 02:26 PM, Simon Marchi wrote:
> 
>> This patch copies the following files from libstdc++ (commit
>> 02a4441f002c):
>> 
>>   ${gcc}/include/std/string_view -> 
>> ${binutils-gdb}/gdb/common/gdb_string_view.h
>>   ${gcc}/include/bits/string_view.tcc -> 
>> ${binutils-gdb}/gdb/common/gdb_string_view.tcc
> 
> Nit: the source filenames here should be updated.  Maybe commit as
> well, if applicable.
> 
> Thanks,
> Pedro Alves

Oops, I'm missing "libstdc++-v3" in the source names.  Is there anything 
else wrong with the paths?  What about the commit?

Simno