From: Simon Marchi <simark@simark.ca>
To: Ali Tamur <tamur@google.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 2/4] DWARF 5 support: Handle DW_FORM_strx
Date: Wed, 18 Sep 2019 03:08:00 -0000 [thread overview]
Message-ID: <f97d5426-86d7-3f84-2919-fb4d9657f1d3@simark.ca> (raw)
In-Reply-To: <20190910184542.256253-1-tamur@google.com>
On 2019-09-10 2:45 p.m., Ali Tamur via gdb-patches wrote:
> Simon Marchi reviewed the first patch in the series but he is out this week,
> and I'm hoping maybe someone else can take a look. This one should not be
> controversial. Thanks.
> ---
>
>
> * Handle DW_FORM_strx forms everywhere.
> * A couple of annoying whitespace corrections.
>
> Tested with CC=/usr/bin/gcc (version 8.3.0) against master branch (also with
> -gsplit-dwarf and -gdwarf-4 flags) and there was no increase in the set of
> tests that fails.
>
> This is part of an effort to support DWARF 5 in gdb.
Hi Ali,
For the whitespace fixes, could you push a separate obvious patch that takes care of that?
Otherwise the patch LGTM.
Simon
prev parent reply other threads:[~2019-09-18 3:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 23:41 [PATCH 1/4] Increasing support for dwarf 5 Ali Tamur via gdb-patches
2019-08-28 5:16 ` Simon Marchi
2019-09-06 21:52 ` [PATCH v2 1/4] DWARF 5 support: Handle dwo_id Ali Tamur via gdb-patches
2019-09-07 20:30 ` Simon Marchi
2019-09-09 18:58 ` Ali Tamur via gdb-patches
2019-09-09 21:21 ` Simon Marchi
2019-09-10 1:37 ` Ali Tamur via gdb-patches
2019-09-10 18:45 ` [PATCH v2 2/4] DWARF 5 support: Handle DW_FORM_strx Ali Tamur via gdb-patches
2019-09-18 3:08 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f97d5426-86d7-3f84-2919-fb4d9657f1d3@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tamur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).