From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50925 invoked by alias); 18 Sep 2019 03:08:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50911 invoked by uid 89); 18 Sep 2019 03:08:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:766, controversial X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Sep 2019 03:08:13 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 465E41E092; Tue, 17 Sep 2019 23:08:11 -0400 (EDT) Subject: Re: [PATCH v2 2/4] DWARF 5 support: Handle DW_FORM_strx To: Ali Tamur , gdb-patches@sourceware.org References: <20190910184542.256253-1-tamur@google.com> From: Simon Marchi Message-ID: Date: Wed, 18 Sep 2019 03:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190910184542.256253-1-tamur@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-09/txt/msg00334.txt.bz2 On 2019-09-10 2:45 p.m., Ali Tamur via gdb-patches wrote: > Simon Marchi reviewed the first patch in the series but he is out this week, > and I'm hoping maybe someone else can take a look. This one should not be > controversial. Thanks. > --- > > > * Handle DW_FORM_strx forms everywhere. > * A couple of annoying whitespace corrections. > > Tested with CC=/usr/bin/gcc (version 8.3.0) against master branch (also with > -gsplit-dwarf and -gdwarf-4 flags) and there was no increase in the set of > tests that fails. > > This is part of an effort to support DWARF 5 in gdb. Hi Ali, For the whitespace fixes, could you push a separate obvious patch that takes care of that? Otherwise the patch LGTM. Simon