From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 1A47B396E474 for ; Tue, 31 May 2022 19:33:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A47B396E474 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 568D921C0D; Tue, 31 May 2022 19:33:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 31E0F13AA2; Tue, 31 May 2022 19:33:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KeT4CnhtlmL7PQAAMHmgww (envelope-from ); Tue, 31 May 2022 19:33:12 +0000 Message-ID: Date: Tue, 31 May 2022 21:33:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 00/16] Fortran compiler identification and ifx testsuite support Content-Language: en-US To: Andrew Burgess , Nils-Christian Kempke , gdb-patches@sourceware.org Cc: JiniSusan.George@amd.com References: <20220531092423.2361679-1-nils-christian.kempke@intel.com> <87ilpld6ho.fsf@redhat.com> From: Tom de Vries In-Reply-To: <87ilpld6ho.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 19:33:15 -0000 On 5/31/22 18:14, Andrew Burgess via Gdb-patches wrote: > Nils-Christian Kempke via Gdb-patches > writes: > >> Hi, >> >> V1 of this series can be found here: >> >> https://sourceware.org/pipermail/gdb-patches/2022-May/188904.html >> >> Changes since v1: >> >> * Patch 03: There were some leftovers in the commit message from an >> earlier version of the patch - these have been removed. >> >> * Patch 04: The commit message has been renamed and a comment been >> adapted according to Andrew's feedback. The getting_compiler_info >> variable now also uses actual bool values. >> >> * Patch 06: The commit message has been adapted and now says that >> the intel C compiler names have not yet been used in the testsuite (to >> avoid confusion as to why there are no changes done in the testsuite). >> >> * Patch 08: This patch has been dropped, instead an ifx bug was filed. >> So from now on the patch numbers will be off by 1. >> >> * Patch 11 (now 10): The comment has been reworded and >> 'need the -debug-parameters all flag set to emit' >> now reads >> 'need the -debug-parameters flag set to emit' >> Also, not only ifx but also ifort requires the flag so it is now added >> for both compilers. >> >> * Patch 13 (now 12): I added a comment to the patch as well as made >> the commit message a lot more elaborate (after some online >> discussion). >> >> * Patch 14: This patch has been dropped for now as we are claifying >> whether ifx should change its debug output. The patch numbers will >> now be off by 2. >> >> * Patch 18 (now 16): The '-wrap' is now used here instead of adding >> the $gdb_prompt in test_multiple. Also, flang was added to the >> comments. >> >> Patch 01, 02, 05, 07, 09 (now 08), 10 (now 09), 12 (now 11), 15 (now 13), >> 16 (now 14), and 17 (now 15) had been approved before and were not >> changed/included here. > > I've approved all these patches now. > > For me I would have preferred to see the complete set of patches > included each time the series is reposted, it makes it easier to apply > the patches. Though I do also appreciate you commenting about which > patches have changed, and what the changes were. > Hi, I'm seeing regressions with check-read1 (haven't tried native yet), I'm guessing because of this patch series: ... FAIL: gdb.fortran/allocated.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/array-bounds-high.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/array-bounds.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/array-indices.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/array-indices.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/array-no-bounds.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/array-repeat.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/array-repeat.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/array-slices-bad.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/array-slices-sub-slices.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/array-slices.exp: repack=on: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/array-slices.exp: repack=off: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/associated.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/assumedrank.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/block-data.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/call-no-debug.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/charset.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Couldn't run to main FAIL: gdb.fortran/class-allocatable-array.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/common-block.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/completion.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/complex.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Couldn't run to main FAIL: gdb.fortran/debug-expr.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/derived-type-function.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/derived-type.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/dynamic-ptype-whatis.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/info-modules.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/info-types.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/intrinsics.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/intvar-array.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/intvar-dynamic-types.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/lbound-ubound.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/library-module.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/logical.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/max-depth.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Could not run to main. FAIL: gdb.fortran/module.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/multi-dim.exp: gdb_breakpoint: set breakpoint at unknown ERROR: Couldn't run to main FAIL: gdb.fortran/namelist.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=0: increment: whatis increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=0: increment: ptype increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=0: increment_program_global: whatis increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=0: increment_program_global: ptype increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: before start: whatis contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: before start: ptype contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: before start: print contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: before start: whatis contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: before start: ptype contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: before start: print contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: increment: whatis contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: increment: ptype contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: increment_program_global: whatis contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=0: nest_prefix=1: increment_program_global: ptype contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=0: increment: whatis increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=0: increment: ptype increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=0: increment_program_global: whatis increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=0: increment_program_global: ptype increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: before start: whatis contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: before start: ptype contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: before start: print contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: before start: whatis contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: before start: ptype contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: before start: print contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: increment: whatis contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: increment: ptype contains_keyword::increment FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: increment_program_global: whatis contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs-2.exp: src_prefix=1: nest_prefix=1: increment_program_global: ptype contains_keyword::increment_program_global FAIL: gdb.fortran/nested-funcs.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/oop_extend_type.exp: gdb_breakpoint: set breakpoint at unknown ERROR: could not run to main FAIL: gdb.fortran/pointer-to-pointer.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/print-formatted.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/print_type.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/printing-types.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/ptr-indentation.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/ptype-on-functions.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/rank.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/shape.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/size.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/subarray.exp: gdb_breakpoint: set breakpoint at unknown ERROR: couldn't run to main FAIL: gdb.fortran/vla-alloc-assoc.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-datatypes.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-history.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-ptr-info.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-ptype-sub.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-ptype.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-sizeof.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-type.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-value-sub-arbitrary.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-value-sub-finish.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-value-sub.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/vla-value.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.fortran/whatis_type.exp: gdb_breakpoint: set breakpoint at unknown FAIL: gdb.mi/mi-fortran-modules.exp: -symbol-info-module-variables FAIL: gdb.mi/mi-var-child-f.exp: get children of array (unexpected output) FAIL: gdb.mi/mi-var-child-f.exp: get grandchildren of array (children of first element of second index) (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: create local variable vla1_not_allocated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: info type variable vla1_not_allocated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: create local variable vla1_allocated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: info type variable vla1_allocated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: get children of vla1_allocated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: create local variable pvla2_not_associated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: info type variable pvla2_not_associated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: create local variable pvla2_associated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: info type variable pvla2_associated (unexpected output) ... Thanks, - Tom