From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 0F1EF3858020 for ; Tue, 10 Jan 2023 15:34:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F1EF3858020 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f48.google.com with SMTP id o15so9091385wmr.4 for ; Tue, 10 Jan 2023 07:34:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rZvd+6vFv27euGrqtiHqD88e8/0OVd88ZBzHaUbTyOg=; b=GYv0jNXDtDRKw1S/Ep0aUZklnRF6Gja0WUBXkwAMb6/1eZY5gOiFGfiI07qYK7kFe+ oRbXF0v6oJfCc7Pibsm8N0ql3lko55KfIX/KIjur0yJXx/jUHqexNjDSd1LCoOl3qOCQ AS1To/kELob1Ds+xfuPLw4hrTC9EVe3DoDi3HonqWPiO29JDQv1EqRI35u53K0JOhRHi jUbTwx5uJSfaPkrdxKf9qEfswMthyOsn1Mv1MH+hV/QF0hBV3mRTgXFHgGZNphJngvc0 nxOzVNTN/YOILw6vmXyE3rsIlq+1sjLO3HG0c337w9DICcwa9o3DXj/Vk3AM25Rjox8J lzYg== X-Gm-Message-State: AFqh2koaXIXv71tmTr//soLH2IKDh3Y8bpQ7Em2q+I998+cvyJzHKrov o/1NYllCqkWtWd9QPXxKmEjvyacRNBYBSR2J X-Google-Smtp-Source: AMrXdXvqC8WrsgEeT7tUJ3j9j4QyHpDctxjUBSSZlFpI2OQMlO/BklTHnpJMhn9JXgFI0hnGD5fijg== X-Received: by 2002:a05:600c:3596:b0:3d2:3b8d:21e5 with SMTP id p22-20020a05600c359600b003d23b8d21e5mr48755479wmq.14.1673364840818; Tue, 10 Jan 2023 07:34:00 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id u8-20020a05600c19c800b003d9780466b0sm17050701wmq.31.2023.01.10.07.34.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 07:34:00 -0800 (PST) Subject: Re: [PATCH] gdb: use gdb_test_multiple in gdb_breakpoint To: Simon Marchi , Tom de Vries , gdb-patches@sourceware.org References: <20230103192216.108444-1-simon.marchi@polymtl.ca> <315f1d7a-a948-5512-fd89-a40d7a25e937@polymtl.ca> From: Pedro Alves Message-ID: Date: Tue, 10 Jan 2023 15:33:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <315f1d7a-a948-5512-fd89-a40d7a25e937@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-05 4:28 p.m., Simon Marchi via Gdb-patches wrote: > --- > gdb/testsuite/lib/gdb.exp | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index e17eace4cb13..af538e5c8fbd 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -657,6 +657,12 @@ proc gdb_breakpoint { linespec args } { > send_gdb "$pending_response\n" > exp_continue > } > + -re "$gdb_prompt $" { > + if { $print_fail } { > + fail $test_name > + } > + return 0 > + } > } The other removed "-re" cases also considered $print_fail, so if their replacement inside gdb_test_multiple is hit, they'll produce a FAIL. Was that intended? Should we instead add a "-nofail" option to gdb_test / gdb_test_multiple ?