From: Keith Seitz <keiths@redhat.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix macro info lookup for binaries containing DWARFv5 line table
Date: Tue, 8 Jun 2021 11:48:36 -0700 [thread overview]
Message-ID: <f9b41def-5deb-da5f-ada9-a1bee17c2fe8@redhat.com> (raw)
In-Reply-To: <a7724df1-cf21-a631-8934-52ee72b3388e@redhat.com>
RFC ping
Anyone at all have an opinion on this direction?
Keith
On 5/24/21 11:47 AM, Keith Seitz via Gdb-patches wrote:
> On 5/24/21 4:36 AM, Tomar, Sourabh Singh wrote:
>> [AMD Public Use]
>>
>> Hello Keith,
>>
>> Could you please share your plan WRT to this patch.
>> Do you want to take it forward ? or you want me to take this forward.
>>
>
> I can pursue this...
>
> In that vein, does anyone (maintainers?) have an input on my "counterpatch"
> (reposted below) that removes this IS_ABSOLUTE_PREFIX stuff and copies the
> symtab's filename?
>
> I haven't officially submitted this as a patch because I'm curious whether
> my reading of this is correct/complete. Maybe the documentation/comments
> are incorrect or no longer valid?
>
> FWIW, I've tested that patch on native x86_64 Fedora 34 with no regressions.
>
> Keith
>
> Patch under discussion:
>
> gdb/ChangeLog
>
> * dwarf2/line-header.c (line_header::file_file_name): Copy
> the symtab's filename.
>
> diff --git a/gdb/dwarf2/line-header.c b/gdb/dwarf2/line-header.c
> index 7575297f966..117c5a42cc5 100644
> --- a/gdb/dwarf2/line-header.c
> +++ b/gdb/dwarf2/line-header.c
> @@ -69,15 +69,10 @@ line_header::file_file_name (int file) const
> {
> const file_entry *fe = file_name_at (file);
>
> - if (!IS_ABSOLUTE_PATH (fe->name))
> - {
> - const char *dir = fe->include_dir (this);
> - if (dir != NULL)
> - return gdb::unique_xmalloc_ptr<char> (concat (dir, SLASH_STRING,
> - fe->name,
> - (char *) NULL));
> - }
> - return make_unique_xstrdup (fe->name);
> + /* macro_source_file requires: "This filename is relative to the
> + compilation directory, it exactly matches the symtab->filename
> + content." */
> + return make_unique_xstrdup (fe->symtab->filename);
> }
> else
> {
>
next prev parent reply other threads:[~2021-06-08 18:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 17:16 Sourabh Singh Tomar
2021-05-12 17:31 ` Tomar, Sourabh Singh
2021-05-13 15:47 ` Tom Tromey
2021-05-13 18:20 ` Simon Marchi
2021-05-14 14:56 ` Keith Seitz
2021-05-14 18:21 ` Tomar, Sourabh Singh
2021-05-14 18:50 ` Simon Marchi
2021-05-14 19:20 ` Tomar, Sourabh Singh
2021-05-14 20:56 ` Simon Marchi
2021-05-24 11:36 ` Tomar, Sourabh Singh
2021-05-24 18:47 ` Keith Seitz
2021-06-08 18:48 ` Keith Seitz [this message]
2021-06-22 17:01 ` [RFC] PING [Re: [PATCH] Fix macro info lookup for binaries containing DWARFv5 line table] Keith Seitz
2021-06-22 20:52 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9b41def-5deb-da5f-ada9-a1bee17c2fe8@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).