From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 12CE03858D37 for ; Sun, 13 Aug 2023 21:29:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12CE03858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 134E421977; Sun, 13 Aug 2023 21:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691962162; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n7zwT8PYaVqp5hb7RVzZkeZ2wbFR0HRdgd+X2dG7/3Q=; b=CJQHOFU7MwJ4BfT7vFw6Joy8+wVwGUZX8kTEy5aZ/HZHrBZffd3HSOvM6EvUB1cwwZsTsX kPSEZK4IPqoCd0lrObCxiawcGwethjYR4FTiAl5VkDEdX8HxW6SjIjMZMBFuRTgL6rSacN b6JUhAZEOyp8EcmKcj+eDbJfakLfDvc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691962162; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n7zwT8PYaVqp5hb7RVzZkeZ2wbFR0HRdgd+X2dG7/3Q=; b=bfZuSVrLMffyX7t5dq7f2cimAIvN826X0wUWdd89bECSxFqgXWl6B5sA052zaY8d8/5nxF XIfcinZ9vomjv5AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EB3D21322C; Sun, 13 Aug 2023 21:29:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9Ip/NzFL2WT+BAAAMHmgww (envelope-from ); Sun, 13 Aug 2023 21:29:21 +0000 Message-ID: Date: Sun, 13 Aug 2023 23:29:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/symtab] Don't deduplicate variables in gdb-index Content-Language: en-US To: Kevin Buettner , Tom de Vries via Gdb-patches Cc: Tom Tromey References: <20230804173542.3357-1-tdevries@suse.de> <20230812211119.20413b22@f37-zws-nv> From: Tom de Vries In-Reply-To: <20230812211119.20413b22@f37-zws-nv> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/13/23 06:11, Kevin Buettner wrote: > On Fri, 4 Aug 2023 19:35:42 +0200 > Tom de Vries via Gdb-patches wrote: > >> Fix this in symtab_index_entry::minimize, by not deduplicating variables. >> >> Tested on x86_64-linux, with target boards unix and cc-with-gdb-index. > > LGTM. > Hi Kevin, thanks for the review, I've pushed this after fixing a typo in the log message and a nit the updated comment. Thanks, - Tom > Reviewed-by: Kevin Buettner >