From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 8AA9B3858D33 for ; Thu, 9 Mar 2023 08:38:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AA9B3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C49A51FF7B; Thu, 9 Mar 2023 08:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678351123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jKjjpaP3rjAOojK2bS8elZYop4gb9n/HI6E9Zt6e0rA=; b=XZhbUtrkMji8xBzc+TO3ZrxRfW9xgJAyyp3dixbCIONVqO5lgOLZ5XtzVpKjKDQxmY1C4s H6rybILZsT4uXx6khn6unVFfUEkEU5m9QuKZ8Zn7p7iz1XtBvah7nqHciQsab5kFI87X+N tUL2HDYBU0tmtVDUaq0HdQ/VyR15zBE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678351123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jKjjpaP3rjAOojK2bS8elZYop4gb9n/HI6E9Zt6e0rA=; b=Bp27WLVyrV9bwPIWmFRVz/Fe0CzV/MZdZ9vk8HPz1TLKHn56xqLoIYqiaSD4DZ9GTi2EWV t02/Jxlpf3Y/FNAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AC79C13A10; Thu, 9 Mar 2023 08:38:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DmjhKBObCWS+cAAAMHmgww (envelope-from ); Thu, 09 Mar 2023 08:38:43 +0000 Content-Type: multipart/mixed; boundary="------------4YkzfdGxM67rmu1xMsSWdDxK" Message-ID: Date: Thu, 9 Mar 2023 09:38:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] Fix DAP stackTrace through frames without debuginfo To: Tom Tromey , Tom Tromey via Gdb-patches References: <20230215194847.3805619-1-tromey@adacore.com> <874jqx7vux.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <874jqx7vux.fsf@tromey.com> X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------4YkzfdGxM67rmu1xMsSWdDxK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/6/23 16:17, Tom Tromey via Gdb-patches wrote: >>>>>> "Tom" == Tom Tromey via Gdb-patches writes: > > Tom> The DAP stackTrace implementation did not fully account for frames > Tom> without debuginfo. Attemping this would yield a result like: > > Tom> {"request_seq": 5, "type": "response", "command": "stackTrace", "success": false, "message": "'NoneType' object has no attribute 'filename'", "seq": 11} > > Tom> This patch fixes the problem by adding another check for None. > > I'm checking this in now. Hi, I'm getting: ... {"request_seq": 5, "type": "response", "command": "stackTrace", "success": false, "message": "unhashable type: 'gdb.Frame'", "seq": 11}FAIL: gdb.dap/bt-nodebug.exp: backtrace success ... This is with python 3.6m. Thanks, - Tom --------------4YkzfdGxM67rmu1xMsSWdDxK Content-Type: text/plain; charset=UTF-8; name="dap.log.1" Content-Disposition: attachment; filename="dap.log.1" Content-Transfer-Encoding: base64 UkVBRDogPDw8eyJzZXEiOiAyLCAidHlwZSI6ICJyZXF1ZXN0IiwgImNvbW1hbmQiOiAibGF1 bmNoIiwgImFyZ3VtZW50cyI6IHsicHJvZ3JhbSI6ICIvZGF0YS92cmllcy9nZGIvbGVhcC0x NS00L2J1aWxkL2dkYi90ZXN0c3VpdGUvb3V0cHV0cy9nZGIuZGFwL2J0LW5vZGVidWcvYnQt bm9kZWJ1ZyJ9fT4+PgpXUk9URTogPDw8eyJyZXF1ZXN0X3NlcSI6IDIsICJ0eXBlIjogInJl c3BvbnNlIiwgImNvbW1hbmQiOiAibGF1bmNoIiwgInN1Y2Nlc3MiOiB0cnVlfT4+PgorKysg ZmlsZSAvZGF0YS92cmllcy9nZGIvbGVhcC0xNS00L2J1aWxkL2dkYi90ZXN0c3VpdGUvb3V0 cHV0cy9nZGIuZGFwL2J0LW5vZGVidWcvYnQtbm9kZWJ1ZwpSRUFEOiA8PDx7InNlcSI6IDMs ICJ0eXBlIjogInJlcXVlc3QiLCAiY29tbWFuZCI6ICJzZXRGdW5jdGlvbkJyZWFrcG9pbnRz IiwgImFyZ3VtZW50cyI6IHsiYnJlYWtwb2ludHMiOiBbeyJuYW1lIjogImZ1bmN0aW9uX2Jy ZWFrcG9pbnRfaGVyZSJ9XX19Pj4+Cj4+PiBSZWFkaW5nIHN5bWJvbHMgZnJvbSAvZGF0YS92 cmllcy9nZGIvbGVhcC0xNS00L2J1aWxkL2dkYi90ZXN0c3VpdGUvb3V0cHV0cy9nZGIuZGFw L2J0LW5vZGVidWcvYnQtbm9kZWJ1Zy4uLgoKV1JPVEU6IDw8PHsidHlwZSI6ICJldmVudCIs ICJldmVudCI6ICJicmVha3BvaW50IiwgImJvZHkiOiB7InJlYXNvbiI6ICJuZXciLCAiYnJl YWtwb2ludCI6IHsiaWQiOiAxLCAidmVyaWZpZWQiOiB0cnVlLCAic291cmNlIjogeyJuYW1l IjogImJ0LW1haW4uYyIsICJwYXRoIjogIi9kYXRhL3ZyaWVzL2dkYi9iaW51dGlscy1nZGIu Z2l0L2dkYi90ZXN0c3VpdGUvZ2RiLmRhcC9idC1tYWluLmMiLCAic291cmNlUmVmZXJlbmNl IjogMH0sICJsaW5lIjogMjMsICJpbnN0cnVjdGlvblJlZmVyZW5jZSI6ICIweDQwMDRhYiJ9 fX0+Pj4KV1JPVEU6IDw8PHsicmVxdWVzdF9zZXEiOiAzLCAidHlwZSI6ICJyZXNwb25zZSIs ICJjb21tYW5kIjogInNldEZ1bmN0aW9uQnJlYWtwb2ludHMiLCAiYm9keSI6IHsiYnJlYWtw b2ludHMiOiBbeyJpZCI6IDEsICJ2ZXJpZmllZCI6IHRydWUsICJzb3VyY2UiOiB7Im5hbWUi OiAiYnQtbWFpbi5jIiwgInBhdGgiOiAiL2RhdGEvdnJpZXMvZ2RiL2JpbnV0aWxzLWdkYi5n aXQvZ2RiL3Rlc3RzdWl0ZS9nZGIuZGFwL2J0LW1haW4uYyIsICJzb3VyY2VSZWZlcmVuY2Ui OiAwfSwgImxpbmUiOiAyMywgImluc3RydWN0aW9uUmVmZXJlbmNlIjogIjB4NDAwNGFiIn1d fSwgInN1Y2Nlc3MiOiB0cnVlfT4+PgpXUk9URTogPDw8eyJ0eXBlIjogImV2ZW50IiwgImV2 ZW50IjogIm91dHB1dCIsICJib2R5IjogeyJjYXRlZ29yeSI6ICJzdGRvdXQiLCAib3V0cHV0 IjogIkJyZWFrcG9pbnQgMSBhdCAweDQwMDRhYjogZmlsZSAvZGF0YS92cmllcy9nZGIvc3Jj L2dkYi90ZXN0c3VpdGUvZ2RiLmRhcC9idC1tYWluLmMsIGxpbmUgMjMuXG4ifX0+Pj4KUkVB RDogPDw8eyJzZXEiOiA0LCAidHlwZSI6ICJyZXF1ZXN0IiwgImNvbW1hbmQiOiAiY29uZmln dXJhdGlvbkRvbmUifT4+PgpXUk9URTogPDw8eyJyZXF1ZXN0X3NlcSI6IDQsICJ0eXBlIjog InJlc3BvbnNlIiwgImNvbW1hbmQiOiAiY29uZmlndXJhdGlvbkRvbmUiLCAic3VjY2VzcyI6 IHRydWV9Pj4+CisrKyBydW4KV1JPVEU6IDw8PHsidHlwZSI6ICJldmVudCIsICJldmVudCI6 ICJ0aHJlYWQiLCAiYm9keSI6IHsicmVhc29uIjogInN0YXJ0ZWQiLCAidGhyZWFkSWQiOiAx fX0+Pj4KX3N1cHByZXNzX2NvbnQgY2FzZQpXUk9URTogPDw8eyJ0eXBlIjogImV2ZW50Iiwg ImV2ZW50IjogImJyZWFrcG9pbnQiLCAiYm9keSI6IHsicmVhc29uIjogImNoYW5nZWQiLCAi YnJlYWtwb2ludCI6IHsiaWQiOiAxLCAidmVyaWZpZWQiOiB0cnVlLCAic291cmNlIjogeyJu YW1lIjogImJ0LW1haW4uYyIsICJwYXRoIjogIi9kYXRhL3ZyaWVzL2dkYi9iaW51dGlscy1n ZGIuZ2l0L2dkYi90ZXN0c3VpdGUvZ2RiLmRhcC9idC1tYWluLmMiLCAic291cmNlUmVmZXJl bmNlIjogMH0sICJsaW5lIjogMjMsICJpbnN0cnVjdGlvblJlZmVyZW5jZSI6ICIweDQwMDRh YiJ9fX0+Pj4KZW50ZXJpbmcgX29uX3N0b3A6IDxnZGIuQnJlYWtwb2ludEV2ZW50IG9iamVj dCBhdCAweDdmZWFkNDVlYjY0OD4KV1JPVEU6IDw8PHsidHlwZSI6ICJldmVudCIsICJldmVu dCI6ICJzdG9wcGVkIiwgImJvZHkiOiB7InRocmVhZElkIjogMSwgImFsbFRocmVhZHNTdG9w cGVkIjogdHJ1ZSwgImhpdEJyZWFrcG9pbnRJZHMiOiBbMV0sICJyZWFzb24iOiAiYnJlYWtw b2ludCJ9fT4+Pgo+Pj4gU3RhcnRpbmcgcHJvZ3JhbTogL2RhdGEvdnJpZXMvZ2RiL2xlYXAt MTUtNC9idWlsZC9nZGIvdGVzdHN1aXRlL291dHB1dHMvZ2RiLmRhcC9idC1ub2RlYnVnL2J0 LW5vZGVidWcgCltzZXR0aW5nIHR0eSBzdGF0ZSBmYWlsZWQgaW4gdGVybWluYWxfaW5mZXJp b3I6IEluYXBwcm9wcmlhdGUgaW9jdGwgZm9yIGRldmljZV0KClJFQUQ6IDw8PHsic2VxIjog NSwgInR5cGUiOiAicmVxdWVzdCIsICJjb21tYW5kIjogInN0YWNrVHJhY2UiLCAiYXJndW1l bnRzIjogeyJ0aHJlYWRJZCI6IDF9fT4+PgorKysgdGhyZWFkIDEKPj4+IFtTd2l0Y2hpbmcg dG8gdGhyZWFkIDEgKHByb2Nlc3MgMjEwOTIpXQojMCAgZnVuY3Rpb25fYnJlYWtwb2ludF9o ZXJlICgpIGF0IC9kYXRhL3ZyaWVzL2dkYi9zcmMvZ2RiL3Rlc3RzdWl0ZS9nZGIuZGFwL2J0 LW1haW4uYzoyMwoyMwl9CgpUcmFjZWJhY2sgKG1vc3QgcmVjZW50IGNhbGwgbGFzdCk6CiAg RmlsZSAiL2RhdGEvdnJpZXMvZ2RiL2xlYXAtMTUtNC9idWlsZC9nZGIvZGF0YS1kaXJlY3Rv cnkvcHl0aG9uL2dkYi9kYXAvc2VydmVyLnB5IiwgbGluZSA3NSwgaW4gX2hhbmRsZV9jb21t YW5kCiAgICBib2R5ID0gX2NvbW1hbmRzW3BhcmFtc1siY29tbWFuZCJdXSgqKmFyZ3MpCiAg RmlsZSAiL2RhdGEvdnJpZXMvZ2RiL2xlYXAtMTUtNC9idWlsZC9nZGIvZGF0YS1kaXJlY3Rv cnkvcHl0aG9uL2dkYi9kYXAvYnQucHkiLCBsaW5lIDkzLCBpbiBzdGFja3RyYWNlCiAgICBy ZXR1cm4gc2VuZF9nZGJfd2l0aF9yZXNwb25zZShsYW1iZGE6IF9iYWNrdHJhY2UodGhyZWFk SWQsIGxldmVscywgc3RhcnRGcmFtZSkpCiAgRmlsZSAiL2RhdGEvdnJpZXMvZ2RiL2xlYXAt MTUtNC9idWlsZC9nZGIvZGF0YS1kaXJlY3RvcnkvcHl0aG9uL2dkYi9kYXAvc3RhcnR1cC5w eSIsIGxpbmUgMTkyLCBpbiBzZW5kX2dkYl93aXRoX3Jlc3BvbnNlCiAgICByYWlzZSB2YWwK ICBGaWxlICIvZGF0YS92cmllcy9nZGIvbGVhcC0xNS00L2J1aWxkL2dkYi9kYXRhLWRpcmVj dG9yeS9weXRob24vZ2RiL2RhcC9zdGFydHVwLnB5IiwgbGluZSAxODQsIGluIG1lc3NhZ2UK ICAgIHZhbCA9IGZuKCkKICBGaWxlICIvZGF0YS92cmllcy9nZGIvbGVhcC0xNS00L2J1aWxk L2dkYi9kYXRhLWRpcmVjdG9yeS9weXRob24vZ2RiL2RhcC9idC5weSIsIGxpbmUgOTMsIGlu IDxsYW1iZGE+CiAgICByZXR1cm4gc2VuZF9nZGJfd2l0aF9yZXNwb25zZShsYW1iZGE6IF9i YWNrdHJhY2UodGhyZWFkSWQsIGxldmVscywgc3RhcnRGcmFtZSkpCiAgRmlsZSAiL2RhdGEv dnJpZXMvZ2RiL2xlYXAtMTUtNC9idWlsZC9nZGIvZGF0YS1kaXJlY3RvcnkvcHl0aG9uL2dk Yi9kYXAvc3RhcnR1cC5weSIsIGxpbmUgNzgsIGluIGVuc3VyZV9nZGJfdGhyZWFkCiAgICBy ZXR1cm4gZnVuYygqYXJncywgKiprd2FyZ3MpCiAgRmlsZSAiL2RhdGEvdnJpZXMvZ2RiL2xl YXAtMTUtNC9idWlsZC9nZGIvZGF0YS1kaXJlY3RvcnkvcHl0aG9uL2dkYi9kYXAvYnQucHki LCBsaW5lIDYyLCBpbiBfYmFja3RyYWNlCiAgICAiaWQiOiBmcmFtZV9pZChjdXJyZW50X2Zy YW1lKSwKICBGaWxlICIvZGF0YS92cmllcy9nZGIvbGVhcC0xNS00L2J1aWxkL2dkYi9kYXRh LWRpcmVjdG9yeS9weXRob24vZ2RiL2RhcC9zdGFydHVwLnB5IiwgbGluZSA3OCwgaW4gZW5z dXJlX2dkYl90aHJlYWQKICAgIHJldHVybiBmdW5jKCphcmdzLCAqKmt3YXJncykKICBGaWxl ICIvZGF0YS92cmllcy9nZGIvbGVhcC0xNS00L2J1aWxkL2dkYi9kYXRhLWRpcmVjdG9yeS9w eXRob24vZ2RiL2RhcC9mcmFtZXMucHkiLCBsaW5lIDQ2LCBpbiBmcmFtZV9pZAogICAgaWYg cGFpciBub3QgaW4gX2ZyYW1lX2lkczoKVHlwZUVycm9yOiB1bmhhc2hhYmxlIHR5cGU6ICdn ZGIuRnJhbWUnCldST1RFOiA8PDx7InJlcXVlc3Rfc2VxIjogNSwgInR5cGUiOiAicmVzcG9u c2UiLCAiY29tbWFuZCI6ICJzdGFja1RyYWNlIiwgInN1Y2Nlc3MiOiBmYWxzZSwgIm1lc3Nh Z2UiOiAidW5oYXNoYWJsZSB0eXBlOiAnZ2RiLkZyYW1lJyJ9Pj4+ClJFQUQ6IDw8PHsic2Vx IjogNiwgInR5cGUiOiAicmVxdWVzdCIsICJjb21tYW5kIjogImRpc2Nvbm5lY3QifT4+PgpX Uk9URTogPDw8eyJyZXF1ZXN0X3NlcSI6IDYsICJ0eXBlIjogInJlc3BvbnNlIiwgImNvbW1h bmQiOiAiZGlzY29ubmVjdCIsICJzdWNjZXNzIjogdHJ1ZX0+Pj4KKysrIHF1aXQKV1JPVEU6 IDw8PHsidHlwZSI6ICJldmVudCIsICJldmVudCI6ICJleGl0ZWQiLCAiYm9keSI6IHsiZXhp dENvZGUiOiAwfX0+Pj4K --------------4YkzfdGxM67rmu1xMsSWdDxK--