From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130080.outbound.protection.outlook.com [40.107.13.80]) by sourceware.org (Postfix) with ESMTPS id 92F0F385735C for ; Tue, 25 Oct 2022 13:23:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 92F0F385735C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Xmqgvy7ZmKqdQDhxO8m8VAMHtWXKVGu5rpCgwsWRFnMID8a/5EHcDKEBMfqFws3Utb5XfoCmKL2+VQtI8LC4IoiIkBo0tIyGv15VCsE9eazuvGJjMFO+SGLhDe679qOo1EVTcwKHgO+K9mJnsQF0/UrKLh6QdkFVFkrqjgGCUTIh4drmroXALuO5MQHNEqZeFdg0UXRd3kEjIFWjmNq0iJqSU0xPUWKg0oJzMPdIVCaDfTOfUSrX0rRuw7j5scjMRNAyq97zIT/8Li+3BWpWoJssMXmuwWeuOGCtfWiIi8Te3iljJGMt4yYqPGnCvaxO8fjYHoz8YbCmdCVZ6PS/Wg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5zTrlX8SrfKiuiyPHnFfsXFeK2G9wE+nrT4zMS+Xje8=; b=amvadVQUQKILcWq9sB71lphzhkXGqqGwnJGV1YEcrg1sNPpWTnJ0Po3XQCdGt4+nVBR3HaoUPGnufClRhN0FCcbR626fW8Pc22z1XEgigHGbyuV18dR6WhvTX/dsdDAf6jsrZYmZ3ljU0Kgvjx/YuU674eyv/18STOiZmdx5H6cPuYS8tOqscYl2ClbybBH2HIXPbaJDfC1v8/8QDBXKRThIQPqy4AvsTATzO91FPFrZgU00/4Lzwr7LDGZSI4s65CizQ1ZslBtS1IC515FBuxkVM6Sm5wg9sfoakvVL1E4m3JkldiZNcp0xrV3cdgfJF50/c9v8N7b7n+P9vh+zBA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5zTrlX8SrfKiuiyPHnFfsXFeK2G9wE+nrT4zMS+Xje8=; b=BPnU/Yn16xXl3puW1PbDrsyzcT2YiuWBiNWF/3HvRswb4H36MSYefsqf9DLC/YtBCAgO4tFVtmBKozcyaj0EmTLy+pLSecq5UwbaiOAYTjBRCjfOWnBUKchanTX+DOq/4WcsT+JG+Dknuh03sh009rOr6iCq78hvGccZkPZHTaQ= Received: from DB6PR1001CA0013.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::23) by GV1PR08MB7988.eurprd08.prod.outlook.com (2603:10a6:150:9c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Tue, 25 Oct 2022 13:23:02 +0000 Received: from DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::33) by DB6PR1001CA0013.outlook.office365.com (2603:10a6:4:b7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.27 via Frontend Transport; Tue, 25 Oct 2022 13:23:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT006.mail.protection.outlook.com (100.127.142.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32 via Frontend Transport; Tue, 25 Oct 2022 13:23:02 +0000 Received: ("Tessian outbound f394866f3f2b:v130"); Tue, 25 Oct 2022 13:23:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d7da10add333e692 X-CR-MTA-TID: 64aa7808 Received: from a05ea2c9ac6c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A77BAA5C-84A0-4C0E-82DF-29EC3C1749B7.1; Tue, 25 Oct 2022 13:22:55 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a05ea2c9ac6c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 25 Oct 2022 13:22:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a29tsvxpQupKXaotVOA9ZmPXRpu8tcja0yjICNPtpKmNcVl0LXYM4lFyXhA7r4S+0jWJ/Ft9GfKW0fHEai8BHZfl3LqtXViCXC8MaEgTfcSKHBx8RFXY4OZxyHcwe9ux2Lmbo+3ftk0EvvyfFhqextU5PjF7OlRuo7DjfOVHl6mgwiv2Vsq9AwnHwC4dI3pcQof/4bELnP+eZrP3SxO8YvkRB5aUX9ysqq73FNfSTmUkAqw+Xl/wC2v1CZYQBxkBaCUppKuvUm+cgVgfLlkLJF8PlZoJdLBL+qpf9CB9gAIYlMMZH4UEGafUKj7F8s0VBWKBbKWFHFxVinMuUcZwkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5zTrlX8SrfKiuiyPHnFfsXFeK2G9wE+nrT4zMS+Xje8=; b=EqgfcK04VkONmBIu53BWOikjbKnyeSAVFWE3P0oOkEpGk4FOXgc2wMMHB99uTsZnu/RybjFP6AOwTfn+eqVWZRAccHLz3sI9jDpv5xb0sY2IwfV3YZ7jiF3d50Jsq2HgflVW9SDI2KsQ6MoVv8BLm3a981xKpWtQ0Sh8riyW7hk7fN85R+MRYxVP5J49BcpFSfCExFmJRTYQ22luzd6yQEszmI711t3Gt4q3CDmJc9yXgQPULljkjxLpL8bMKDnGOK0erJWSMr8yk2gC0VZAe5SGbVlG8NkJKf9Fdi3HGyMNFBVmsuDolCNmdeNd6aKaikGwzNd7iTzb/MvnEn8qVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5zTrlX8SrfKiuiyPHnFfsXFeK2G9wE+nrT4zMS+Xje8=; b=BPnU/Yn16xXl3puW1PbDrsyzcT2YiuWBiNWF/3HvRswb4H36MSYefsqf9DLC/YtBCAgO4tFVtmBKozcyaj0EmTLy+pLSecq5UwbaiOAYTjBRCjfOWnBUKchanTX+DOq/4WcsT+JG+Dknuh03sh009rOr6iCq78hvGccZkPZHTaQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB8443.eurprd08.prod.outlook.com (2603:10a6:20b:567::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.40; Tue, 25 Oct 2022 13:22:53 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7f57:1601:9b18:7529]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7f57:1601:9b18:7529%7]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022 13:22:53 +0000 Message-ID: Date: Tue, 25 Oct 2022 14:22:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] gdb/arm: fix IPSR field test in arm_m_exception_cache () Content-Language: en-US To: Tomas Vanek , gdb-patches@sourceware.org References: <1666427154-22766-1-git-send-email-vanekt@fbl.cz> From: Luis Machado In-Reply-To: <1666427154-22766-1-git-send-email-vanekt@fbl.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0087.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::20) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB8443:EE_|DBAEUR03FT006:EE_|GV1PR08MB7988:EE_ X-MS-Office365-Filtering-Correlation-Id: d7812489-b4f6-41a5-db59-08dab68c0b2c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: R1EFi7pInfb2KbQm2LkSI73o8S1XDsQ+APFKtLfNHhX9Zw7objbaIuti16NOmWgZVLaUj0jbAnuaKxoT4jW0EIj662O3jpZMnsNrH2AYU+kAwOcmWUc3K1B4aXQWnkK9oy2GXq309HTAeopEToPgdcxBxMhvD1pQTmIyB4D+YY9W1foL901jDS49gy6EMR3dAzJVIHZnD9+uxzmy9/kzT1OjXY3Xa4rhpLmQIioj4RGBpICkMqmAt9rfA6FYAED0yDNws5UciJ5p5vqFdkJKvtaS3nlIOtgindavNpFo978a9AUPCjb4f5gVujKxDloR9DXE08TdV5f8eZZDEOFQ8scE5SHIGGs8sygCVcB/d7M2aZ2lm7L3oQf2Em5140ZLpG0UEhCzva04Dqe4GDad93f0Vcz/UUVe1/DWQaoWznCLgcluIPtSzJUz8/aDMPbCDrNUsVx74JWa0InGGuB32VvjLXXEdhwPcdxoMrLxezu8V110po0LdvCk9xaQcb8wJoA2XHiuxOijN9UQRhXb7GoMsvX4SpXJTr+UB6EKaWIsv9aCWOSnAJNnwVR2IOWXZGNIzMm8ZZmBHXVEPJ20tkRBnwZ+rNw/tP/zfpnE0kpsscL9+101fnCtp4RHKMZez/o3UQ6n3Wn5ZIIIu+WU5IC88HowE0v67WQGLjhTEEKI5jsW2/EC4IUjyiXaiIi+fSeAMl5hd8wIOiPR7+Upxcne1WEc28aX1xzpemzRjyirHoJaA3V7mwgGA2WpDX7EdhOqvgJ2hHJzg4srOEcbKqYNtqzTtsqc7nKdEhRvFMQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(366004)(376002)(346002)(136003)(39860400002)(451199015)(5660300002)(8936002)(41300700001)(26005)(66556008)(6512007)(66946007)(66476007)(53546011)(36756003)(8676002)(316002)(6506007)(2906002)(186003)(38100700002)(44832011)(2616005)(86362001)(31696002)(83380400001)(478600001)(6486002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8443 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c3a8672c-de7f-4c50-0759-08dab68c0545 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BSbLPUcOjCSIGfSlt+K/VcZje5RmEENRUhOzCzsw729FqlqQTBlxz67dbAs7uTzZQlFOseq3uIvcBh8baKFNl0bmYH+1oKXapitczqspow5v8JRp6HYG5vY12DLCRugBOlW2Yh9HvNabL5kum29oiaX1UKFr6j2/4k5TcE61Kunrz2GYhclphvcHySnFHdD2y/IsVwLxcytJnjJ+HYuFU2kxFsh03vf48EH63kbcXnl8nPB4Oa0uuEQGQhMbJuCOCOH2VBBTxXq1cY0+EXNveRNAhf25EMWoPjyQGQkId1zFrNSO1Ih/nwk+iO2GXWcF8Mwd9uv3GFzTaeH0v6SWyjpbcdgIGW9Lr33H9LvbevIeznZIcuQ6LTG7uhsr9xSvGDMMoynBhMQjYMGN1j7Y0lZ/pnUDJqcaVfFpn09Iiz94Ox7PYWjkOlUhCNkPL4Wjpd62lYkOPmXr4m4O584IooAI5xG5qCsTMdXASxp14cOiEFFmpPg2g3hqGGowDjUwfM7Qj/a4qiCG73LvEMMe7P+vc9wv//EwlCJ9zVUeEreSJQTztKoZhsU6nS2O/3EKgYkz5CSviN2KB4YcdocJEmBRqlzAjWrO1ZZ0KnjyDIjvz+zMWtpsSeqifJHTh1tXOf/Wewr7BqJeuY7EjFmK/NHMhv2FuFTSgeuV4gHpiMmFpUdoDbANELtJbEMDbWXlfemtGegvpGp3CHmJZ1b5iCULxnCyCQoz130vFn3MTvSETNPYV/u0gbhg68P28CKAzlAK/zqxEdLCnVYw0nHqeczR9Lz8GPzWJuNj4eIDBNK77J3kFAWqMzIQ5kYzGh9Y X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(396003)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(31696002)(6486002)(40480700001)(86362001)(316002)(31686004)(70586007)(8676002)(70206006)(83380400001)(186003)(2906002)(336012)(6512007)(26005)(36756003)(82310400005)(81166007)(6506007)(47076005)(82740400003)(356005)(2616005)(40460700003)(36860700001)(41300700001)(53546011)(478600001)(8936002)(5660300002)(44832011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 13:23:02.5356 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d7812489-b4f6-41a5-db59-08dab68c0b2c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7988 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tomas, On 10/22/22 09:25, Tomas Vanek wrote: > Arm v8-M Architecture Reference Manual, > D1.2.141 IPSR, Interrupt Program Status Register reads > "Exception, bits [8:0]" > > 9 bits, not 8! It is uncommon but true! > > Signed-off-by: Tomas Vanek > --- > gdb/arm-tdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index b397ca3..923447a 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -3441,7 +3441,7 @@ struct frame_unwind arm_stub_unwind = { > } > > ULONGEST xpsr = get_frame_register_unsigned (this_frame, ARM_PS_REGNUM); > - if ((xpsr & 0xff) != 0) > + if ((xpsr & 0x1ff) != 0) > /* Handler mode: This is the mode that exceptions are handled in. */ > arm_cache_switch_prev_sp (cache, tdep, tdep->m_profile_msp_s_regnum); > else Good catch. This LGTM. I suppose you need us to push this patch on your behalf? One thing that would be nice to do is to have a flags/fields type for XPSR, which would then display things in a nicer way to the user. Something like CPSR for a-profile.