From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 2941C3858D38 for ; Mon, 3 Oct 2022 18:37:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2941C3858D38 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A33061F38C; Mon, 3 Oct 2022 18:37:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8CD7E1332F; Mon, 3 Oct 2022 18:37:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xIwnIeorO2MVPwAAMHmgww (envelope-from ); Mon, 03 Oct 2022 18:37:30 +0000 Message-ID: Date: Mon, 3 Oct 2022 20:37:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 00/29] Step over thread clone and thread exit Content-Language: en-US From: Tom de Vries To: Pedro Alves , gdb-patches@sourceware.org References: <20220713222433.374898-1-pedro@palves.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2022 18:37:40 -0000 On 10/3/22 15:46, Tom de Vries wrote: > On 7/14/22 00:24, Pedro Alves wrote: >> Tested on x86-64 Ubuntu 20.04, native and gdbserver. >> > > FYI, I applied on the base commit, and tried to build (with > --enable-targets=all), and ran into: > ... > /home/vries/gdb_versions/devel/src/gdb/rs6000-tdep.c:1097:64: error: no > matching function for call to ‘displaced_step_buffers::finish(gdbarch*&, > thread_info*&, gdb_signal&)’ >    return per_inferior->disp_step_buf->finish (arch, thread, sig); >                                                                 ^ > ... > and: > ... > /home/vries/gdb_versions/devel/src/gdb/rs6000-tdep.c:8353:72: error: > invalid conversion from ‘displaced_step_finish_status (*)(gdbarch*, > thread_info*, gdb_signal)’ to ‘displaced_step_finish_status > (*)(gdbarch*, thread_info*, const target_waitstatus&)’ [-fpermissive] >    set_gdbarch_displaced_step_finish (gdbarch, ppc_displaced_step_finish); >                                                                         ^ > ... > > I'll try again without --enable-targets=all. That went ok, so I did a testsuite run, using taskset -c 0 (which for me triggers PR24845). So, PR24845 is gone with this series, which is great. I'm though running into: ... FAIL: gdb.threads/stepi-over-clone.exp: continue FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: stepi FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: $thread_count == 2 ... ... The first FAIL looks like: ... (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch syscall clone continue^M Continuing.^M ^M Catchpoint 2 (call to syscall clone), clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:78^M 78 ../sysdeps/unix/sysv/linux/x86_64/clone.S: No such file or directory.^M (gdb) FAIL: gdb.threads/stepi-over-clone.exp: continue ... and AFAICT the corresponding check is: ... gdb_test "continue" \ "Catchpoint $decimal \\(call to syscall clone\\), $hex in clone \\(\\)" ... so, that looks like some kind to debuginfo difference to me: I don't have glibc-debuginfo installed, but I guess the static library contains some debug info. So, AFAICT, nothing serious. Thanks, - Tom