From: Simon Marchi <simark@simark.ca>
To: Luis Machado <luis.machado@linaro.org>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] gdb: print unknown part of flag enum in hex
Date: Mon, 17 Feb 2020 18:59:00 -0000 [thread overview]
Message-ID: <fa26e0e0-8e50-7e36-11e8-769137c2b05b@simark.ca> (raw)
In-Reply-To: <801f3b0d-d452-101f-7f12-b5d0299a0307@linaro.org>
On 2020-02-17 6:04 a.m., Luis Machado wrote:
> On 2/13/20 5:30 PM, Simon Marchi wrote:
>> When we print the "unknown" part of a flag enum, it is printed in
>> decimal. I think it would be more useful if it was printed in hex, as
>> it helps to determine which bits are set more than a decimal value.
>>
>
> Would it be better to mention the offending bit position explicitly? The hex value could be displayed along with it as well.
>
> I mean, in both decimal and hex you'd need to do some calculations to figure out the bit position anyway. Might as well make it easier for developers by displaying the information.
It's much easier to convert between hex and bit positions than decimal and
bit positions, so I wouldn't put decimal and hex on the same level here.
Also, there could be many bits that are set and unknown, so if we mention them
explicitly, it could take a lot of space and become actually less readable. I
think that the hex notation is the most convenient, it's compact and people are
used to converting between hex and binary on the spot.
Simon
next prev parent reply other threads:[~2020-02-17 18:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:30 [PATCH 1/5] gnulib: import count-one-bits module and use it Simon Marchi
2020-02-13 20:30 ` [PATCH 5/5] gdb: change print format of flag enums with value 0 Simon Marchi
2020-02-17 12:08 ` Luis Machado
2020-02-17 19:02 ` Simon Marchi
2020-02-18 20:45 ` Tom Tromey
2020-02-18 20:52 ` Simon Marchi
2020-02-13 20:30 ` [PATCH 2/5] gdb: fix printing of flag enums with multi-bit enumerators Simon Marchi
2020-02-17 10:56 ` Luis Machado
2020-02-17 17:27 ` Simon Marchi
2020-02-17 17:40 ` Luis Machado
2020-02-17 19:20 ` Simon Marchi
2020-02-18 20:42 ` Tom Tromey
2020-02-13 20:30 ` [PATCH 3/5] gdb: allow duplicate enumerators in flag enums Simon Marchi
2020-02-17 11:01 ` Luis Machado
2020-02-18 20:38 ` Tom Tromey
2020-02-18 20:42 ` Tom Tromey
2020-02-18 20:48 ` Simon Marchi
2020-02-18 21:57 ` Tom Tromey
2020-02-18 22:25 ` Simon Marchi
2020-02-13 20:38 ` [PATCH 4/5] gdb: print unknown part of flag enum in hex Simon Marchi
2020-02-17 11:04 ` Luis Machado
2020-02-17 18:59 ` Simon Marchi [this message]
2020-02-18 20:43 ` Tom Tromey
2020-02-14 19:53 ` [PATCH 1/5] gnulib: import count-one-bits module and use it Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa26e0e0-8e50-7e36-11e8-769137c2b05b@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).