From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0E27C3858D32 for ; Mon, 29 Aug 2022 15:48:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E27C3858D32 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AF8451E222; Mon, 29 Aug 2022 11:48:25 -0400 (EDT) Message-ID: Date: Mon, 29 Aug 2022 11:48:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] gdb: update ranged_breakpoint::print_one_detail in comments Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org Cc: enze.li@gmx.com References: From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2022 15:48:32 -0000 On 2022-08-29 08:24, Enze Li via Gdb-patches wrote: > The print_one_detail_ranged_breakpoint has been renamed to > ranged_breakpoint::print_one_detail in this commit: > > commit ec45bb676c9c69c30783bcf35ffdac8280f3b8bc > Date: Sat Jan 15 16:34:51 2022 -0700 > > Convert ranged breakpoints to vtable ops > > So their comments should be updated as well. > --- > gdb/breakpoint.c | 2 +- > gdb/breakpoint.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 8f0b19f8518..63feea9e9cd 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -9215,7 +9215,7 @@ ranged_breakpoint::print_one (bp_location **last_loc) const > > if (opts.addressprint) > /* We don't print the address range here, it will be printed later > - by print_one_detail_ranged_breakpoint. */ > + by ranged_breakpoint::print_one_detail. */ > uiout->field_skip ("addr"); > annotate_field (5); > print_breakpoint_location (this, bl); > diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h > index 93f30c9c13d..360fa760577 100644 > --- a/gdb/breakpoint.h > +++ b/gdb/breakpoint.h > @@ -691,7 +691,7 @@ struct breakpoint > breakpoint description in "info breakpoints". > > In the example below, the "address range" line was printed > - by print_one_detail_ranged_breakpoint. > + by ranged_breakpoint::print_one_detail. > > (gdb) info breakpoints > Num Type Disp Enb Address What Thanks, this is OK. Simon