From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3555 invoked by alias); 2 May 2018 23:58:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3536 invoked by uid 89); 2 May 2018 23:58:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 May 2018 23:58:12 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BDC328D685 for ; Wed, 2 May 2018 23:58:10 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56670215CDA7 for ; Wed, 2 May 2018 23:58:10 +0000 (UTC) Subject: Re: [PATCH] More procfs.c simplification To: gdb-patches@sourceware.org References: <20180412165934.27722-1-palves@redhat.com> From: Pedro Alves Message-ID: Date: Wed, 02 May 2018 23:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180412165934.27722-1-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00029.txt.bz2 On 04/12/2018 05:59 PM, Pedro Alves wrote: > There are only two architectures using procfs.c (i386/SPARC), and none > of their corresponding nat files overrides any target method. Move > the add_target calls to procfs.c directly. > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call > procfs_target/add_target here. > * procfs.c (procfs_target): Make static. > (_initialize_procfs): Call add_target here. > * procfs.h (struct target_ops): Remove forward declaration. > (procfs_target): Remove declaration. > * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Delete. I pushed this one in too. Thanks, Pedro Alves