From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54305 invoked by alias); 19 Oct 2016 21:18:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53510 invoked by uid 89); 19 Oct 2016 21:18:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=disappears X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Oct 2016 21:18:12 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5A4778123D; Wed, 19 Oct 2016 21:18:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9JLIAD1017192; Wed, 19 Oct 2016 17:18:10 -0400 Subject: Re: [PATCH v2 02/31] cli/cli-script.c: Remove some dead NULL checks To: Simon Marchi References: <1476839539-8374-1-git-send-email-palves@redhat.com> <1476839539-8374-3-git-send-email-palves@redhat.com> <4cc5cb88f049b2ded83eb58a30a93eb5@simark.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 19 Oct 2016 21:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <4cc5cb88f049b2ded83eb58a30a93eb5@simark.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00584.txt.bz2 On 10/19/2016 06:24 PM, Simon Marchi wrote: > On 2016-10-18 21:11, Pedro Alves wrote: >> @@ -853,8 +845,6 @@ insert_args (char *line) >> >> /* Allocate space for the new line and fill it in. */ >> new_line = (char *) xmalloc (len + 1); >> - if (new_line == NULL) >> - return NULL; >> >> /* Restore pointer to beginning of old line. */ >> line = save_line; > > A few lines higher in insert_args, there is: > > error (_("Missing argument %d in user function."), i); > return NULL; > > That return NULL is also dead code and could be confusing, leading > someone to think insert_args can return NULL. I think you could remove > it at the same time. Ah. Guess I missed it because that code disappears with patch (patch #4). I wrote patches #2-#4 as a single patch, and then missed that when I split them to ease review... :-) I've changed this locally. Thanks, Pedro Alves