From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 152E6389850C for ; Wed, 7 Dec 2022 16:54:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 152E6389850C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2B7GseHC019065 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Dec 2022 11:54:45 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2B7GseHC019065 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1670432085; bh=2N4GAAExBnLCfS3FK1jfLJJ2KcEIYBYcPx3ue+T9aZM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Xv8l9fNr5TuCTMHkbwK9slEbnyn5PwueflxBxhtegq+AMk7HYN+gDc1uquHnz4U8V L5zij9XPwv6ZxUt6cp+VHi0gRYBOnDTWwUpMNW0QPfnpK9knWzSukGPaCHLeWQ1Keo gob3S2ZR/d6X7cRQX48NbOolj2xWP0jGWuBiP470= Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8DDCC1E0D3; Wed, 7 Dec 2022 11:54:40 -0500 (EST) Message-ID: Date: Wed, 7 Dec 2022 11:54:39 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/6] gdb: add invalidate_selected_frame function Content-Language: fr To: Bruno Larsen , gdb-patches@sourceware.org References: <20221202180052.212745-1-simon.marchi@polymtl.ca> <20221202180052.212745-2-simon.marchi@polymtl.ca> <4e408f03-21d4-fb9e-ac63-850428a03718@redhat.com> From: Simon Marchi In-Reply-To: <4e408f03-21d4-fb9e-ac63-850428a03718@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 7 Dec 2022 16:54:40 +0000 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/7/22 09:09, Bruno Larsen wrote: > On 02/12/2022 19:00, Simon Marchi via Gdb-patches wrote: >> Instead of using `select_frame (nullptr)` to invalidate the selected >> frame, introduce a function to do that.  There is no change in behavior, >> but it makes the intent a bit clearer.  It also allows adding an assert >> in select_frame that fi is not nullptr, so it avoids passing nullptr by >> mistake. > > LGTM, and doesn't introduce any regressions > > Reviewed-By: Bruno Larsen Thanks, I pushed it since it's independent from the rest. Simon