From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A29753858D39 for ; Thu, 27 Jul 2023 21:48:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A29753858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 36RLmKOR025400 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jul 2023 17:48:25 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 36RLmKOR025400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1690494505; bh=h9JlvrAFuj7OMdwrALkKiCNwm/gJoug8J5FypHAQX/8=; h=Date:Subject:To:References:From:In-Reply-To:From; b=Ve1RUupNU9HVzU2c02n2OxLn/uXj7LpcEnWqcHtkcjlMTisViB5JfdzLL5VkJHoAR hgohU58UzoQW7zHb6q8ZBLF3KYgdZ4KBod00UBCxWUm3NcyZh/V24T00nfponZ5gnL qpv4EJKHB1VeeZP1mlnoxHNkJQJ1w3NjbdrCKzwY= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 331601E00F; Thu, 27 Jul 2023 17:48:20 -0400 (EDT) Message-ID: Date: Thu, 27 Jul 2023 17:48:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 08/15] gdb: Update x86 Linux architectures to support XSAVE layouts. Content-Language: en-US To: John Baldwin , gdb-patches@sourceware.org References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-9-jhb@FreeBSD.org> <45c8bfbf-42d2-c9d9-d246-0ffd6fc4668c@polymtl.ca> <70fd2a39-f5a4-7188-dd8c-4e0eda971733@FreeBSD.org> From: Simon Marchi In-Reply-To: <70fd2a39-f5a4-7188-dd8c-4e0eda971733@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 27 Jul 2023 21:48:20 +0000 X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Ooo, that's a good catch. This function is shared with amd64, so I think > it's best if it keeps returning an xcr0 value, but we could patch > i386_linux_core_read_description to instead do this: > > static const struct target_desc * > i386_linux_core_read_description (struct gdbarch *gdbarch, > struct target_ops *target, > bfd *abfd) > { > /* Linux/i386. */ > x86_xsave_layout layout; > uint64_t xcr0 = i386_linux_core_read_xsave_info (abfd, layout); > if (xcr0 == X86_XSTATE_X87_MASK > && bfd_get_section_by_name (abfd, ".reg-xfp") != NULL) > xcr0 = X86_XSTATE_SSE_MASK; > > return i386_linux_read_description (xcr0); > } And i386_linux_core_read_xsave_info would return X86_XSTATE_X87_MASK if it does not find a .reg-xstate section? Simon