From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79993 invoked by alias); 27 May 2016 10:45:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79886 invoked by uid 89); 27 May 2016 10:45:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 May 2016 10:44:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C2BAC05B1EE; Fri, 27 May 2016 10:44:52 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4RAioBN021771; Fri, 27 May 2016 06:44:50 -0400 Subject: Re: [PATCH 2/4] Rename target descriptors to reflect actual content of descriptor. To: Michael Sturm , mark.kettenis@xs4all.nl, eliz@gnu.org References: <1463143833-24399-1-git-send-email-michael.sturm@intel.com> <1463143833-24399-3-git-send-email-michael.sturm@intel.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 27 May 2016 10:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1463143833-24399-3-git-send-email-michael.sturm@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00482.txt.bz2 It's "target descriptions", not "target descriptors": https://sourceware.org/gdb/current/onlinedocs/gdb/Target-Descriptions.html#Target-Descriptions That typo appears in a lot of places. On 05/13/2016 01:50 PM, Michael Sturm wrote: > To better reflect the actual feature set covered by the IA target > descriptors, the existing descriptors are renamed. Each feature of > the extended state is added to the name of a descriptor or xstate mask > starting from AVX. > For example, amd64-mpx-avx512-linux becomes amd64-avx-mpx-avx512-linux, > while amd64-avx-linux remains unchanged. > Likewise, the corrsponding xstate masks are changed, e.g. from "corresponding" > X86_XSTATE_MPX_AVX512_MASK to X86_XSTATE_AVX_MPX_AVX512_MASK. > > gdb/Changelog: > 2016-04-18 Michael Sturm > > * amd64-linux-tdep.c (features/i386/amd64-avx512-linux.c): Renamed > include. > (features/i386/x32-avx512-linux.c): Likewise. > (amd64_linux_core_read_description): Renamed X86_XSTATE_MPX_AVX512_MASK, > X86_XSTATE_AVX512_MASK, desc_x32_avx512_linux, tdesc_amd64_avx512_linux. > (_initialize_amd64_linux_tdep): Renamed > initialize_tdesc_amd64_avx512_linux, initialize_tdesc_x32_avx512_linux. > * amd64-linux-tdep.h (tdesc_amd64_avx512_linux): Renamed prototype. > (tdesc_x32_avx512_linux): Likewise. > * amd64-tdep.c (features/i386/amd64-avx512.c): Renamed include. > (features/i386/x32-avx512.c): Likewise. > (amd64_target_description): Renamed X86_XSTATE_MPX_AVX512_MASK, > X86_XSTATE_AVX512_MASK, tdesc_amd64_avx512. > (_initialize_amd64_tdep): Renamed initialize_tdesc_amd64_avx512. Renamed > initialize_tdesc_x32_avx512. > * common/x86-xstate.h (X86_XSTATE_AVX512_MASK): Renamed. > (86_XSTATE_MPX_AVX512_MASK): Likewise. > (X86_XSTATE_ALL_MASK): Renamed X86_XSTATE_MPX_AVX512_MASK. > * features/Makefile (WHICH): Renamed i386/i386-avx512, > i386/i386-avx512-linux, i386/amd64-avx512, i386/amd64-avx512-linux, > i386/x32-avx512, i386/x32-avx512-linux. > (i386/i386-avx512-expedite, i386/i386-avx512-linux-expedite, > i386/amd64-avx512-expedite, i386/amd64-avx512-linux-expedite, > i386/x32-avx512-expedite, i386/x32-avx512-linux-expedite): Renamed > expedites. > (XMLTOC): Renamed i386/amd64-avx512-linux.xml, i386/amd64-avx512.xml, > i386/i386-avx512-linux.xml, i386/i386-avx512.xml, > i386/x32-avx512-linux.xml, i386/x32-avx512.xml. > ($(outdir)/i386/i386-avx512.dat): Renamed dat file in rule. > ($(outdir)/i386/i386-avx512-linux.dat): Likewise. > ($(outdir)/i386/amd64-avx512.dat): Likewise. > ($(outdir)/i386/amd64-avx512-linux.dat): Likewise. > ($(outdir)/i386/x32-avx512.dat): Likewise. > ($(outdir)/i386/x32-avx512-linux.dat): Likewise. > * features/i386/amd64-avx512-linux.c: Regenerated from renamed XML file. > * features/i386/amd64-avx512-linux.xml: Renamed XML file. > * features/i386/amd64-avx512.c: Regenerated from renamed XML file. > * features/i386/amd64-avx512.xml: Renamed XML file. > * features/i386/i386-avx512-linux.c: Regenerated from renamed XML file. > * features/i386/i386-avx512-linux.xml: Renamed XML file. > * features/i386/i386-avx512.c: Regenerated from renamed XML file. > * features/i386/i386-avx512.xml: Renamed XML file. > * features/i386/x32-avx512-linux.c: Regenerated from renamed XML file. > * features/i386/x32-avx512-linux.xml: Renamed XML file. > * features/i386/x32-avx512.c: Regenerated from renamed XML file. > * features/i386/x32-avx512.xml: Renamed XML file. > * i386-linux-tdep.c (features/i386/i386-avx512-linux.c): Renamed include. > (i386_linux_core_read_description): Renamed X86_XSTATE_MPX_AVX512_MASK, > X86_XSTATE_AVX512_MASK, tdesc_i386_avx512_linux. > (_initialize_i386_linux_tdep): Renamed initialize_tdesc_i386_avx512_linux. > * i386-linux-tdep.h (tdesc_i386_avx512_linux): Renamed prototype. > * i386-tdep.c (features/i386/i386-avx512.c): Renamed include. > (i386_register_reggroup_p): Renamed X86_XSTATE_AVX512_MASK. > (i386_validate_tdesc_p): Likewise. > (i386_target_description): Renamed X86_XSTATE_MPX_AVX512_MASK, > tdesc_i386_avx512. > (_initialize_i386_tdep): Renamed initialize_tdesc_i386_avx512. > * regformats/i386/amd64-avx512-linux.dat: Regenerated from renamed XML > file. > * regformats/i386/amd64-avx512.dat: Likewise. > * regformats/i386/i386-avx512-linux.dat: Likewise. > * regformats/i386/i386-avx512.dat: Likewise. > * regformats/i386/x32-avx512-linux.dat: Likewise. > * regformats/i386/x32-avx512.dat: Likewise. > * x86-Linux-nat.c (x86_linux_read_description): Renamed > X86_XSTATE_MPX_AVX512_MASK, X86_XSTATE_AVX512_MASK, > tdesc_x32_avx512_linux, tdesc_amd64_avx512_linux, tdesc_i386_avx512_linux. > > gdbserver/Changelog: > 2016-04-18 Michael Sturm > > * Makefile.in (clean): Renamed i386-avx512.c, i386-avx512-linux.c, > amd64-avx512.c, amd64-avx512-linux.c, x32-avx512.c, x32-avx512-linux.c. > (i386-avx512-linux-ipa.o): Renamed rule and source files. > (amd64-avx512-linux-ipa.o): Likewise. > (i386-avx512.c): Renamed rule, source fils and dat files. > (i386-avx512-linux.c): Likewise. > (amd64-avx512.c): Likewise. > (amd64-avx512-linux.c): Likewise. > (x32-avx512.c): Likewise. > (x32-avx512-linux.c): Likewise. > * configfure.srv (srv_i386_regobj): Renamed i386-avx512.o. > (i386_linux_regobj): Renamed i386-avx512-linux.o. > (srv_amd64_regobj): Renamed amd64-avx512.o, x32-avx512.o. > (srv_amd64_linux_regobj): Renamed amd64-avx512-linux.o, > x32-avx512-linux.o. > (ipa_i386_linux_regobj): Renamed i386-avx512-linux-ipa.o. > (ipa_amd64_linux_regobj): Renamed amd64-avx512-linux-ipa.o. > (srv_i386_xmlfiles): Renamed i386/i386-avx512.xml. > (srv_amd64_xmlfiles): Renamed i386/amd64-avx512.xml, i386/x32-avx512.xml. > (srv_i386_linux_xmlfiles): Renamed i386/i386-avx512-linux.xml. > (srv_amd64_linux_xmlfiles): Renamed i386/amd64-avx512-linux.xml, > i386/x32-avx512-linux.xml). > * linux-amd64-ipa.c (get_ipa_tdesc): Renamed X86_TDESC_AVX512 and returned > tdesc for that case. > (initialize_low_tracepoint): Renamed init_registers_amd64_avx512_linux. > * linux-i386-ipa.c (get_ipa_tdesc): Rename X86_TDESC_AVX512 and tdesc > returned for that case. > (initialize_low_tracepoint): Renamed init_registers_i386_avx512_linux. > * linux-x86-low.c (x86_linux_read_description): Renamed > X86_XSTATE_AVX512_MASK and tdesc returned for that case. > (x86_get_ipa_tdesc_idx): Renamed tdesc_amd64_avx512_linux, > tdesc_x32_avx512_linux and mask returned for these descriptors. > Renamed tdesc_i386_avx512_linux and mask returned for that descriptor. > (initialize_low_arch): Renamed init_registers_amd64_avx512_linux, > init_registers_x32_avx512_linux, init_registers_i386_avx512_linux. > * linux-x86-tdesc.h (enum x86_linux_tdesc): Renamed X86_TDESC_AVX512. > (init_registers_amd64_avx512_linux): Renamed prototype. > (tdesc_amd64_avx512_linux): Likewise. > (init_registers_x32_avx512_linux): Likewise. > (tdesc_x32_avx512_linux): Likewise. > (init_registers_i386_avx512_linux): Likewise. > (tdesc_i386_avx512_linux): Likewise. Say "Rename", "Regenerate", etc., as if you were giving order to the code. What I skimmed looked OK, but please re-post a "git diff -M" version, so that we can see through the file renames. Thanks, Pedro Alves