Re: [PATCH] Make addrmap const-correct in cooked index

[Simon Marchi <simark@simark.ca>]

On 1/30/23 09:26, Tom Tromey via Gdb-patches wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
> 
> Simon> So, I redesigned my patch to instead provide both const and non-const
> Simon> versions of find and foreach.  I think it's typical for containers in
> Simon> C++ anyway.  See v2 below:
> 
> This looks good to me.  It addresses my objections.

Thanks, will push.

> Simon> diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c
> Simon> index ced58eab6612..7b1b2d6520cb 100644
> Simon> --- a/gdb/dwarf2/index-write.c
> Simon> +++ b/gdb/dwarf2/index-write.c
> Simon> @@ -474,7 +474,7 @@ add_address_entry (data_buf &addr_vec,
> Simon>  int
> Simon>  addrmap_index_data::operator() (CORE_ADDR start_addr, void *obj)
> Simon>  {
> Simon> -  dwarf2_per_cu_data *per_cu = (dwarf2_per_cu_data *) obj;
> Simon> +  dwarf2_per_cu_data *per_cu = static_cast<dwarf2_per_cu_data *> (obj);
> 
> This area could probably be constified at some point.

I think it will be, when applying you patch that constifies
cooked_index_vector::get_addrmaps.

Simon