From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lsix@lancelotsix.com>,
Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 04/14] gdb: remove BLOCK_MULTIDICT macro
Date: Thu, 21 Apr 2022 13:49:29 -0400 [thread overview]
Message-ID: <fb446d6e-87d4-89f8-3b4b-cd43b6aca429@simark.ca> (raw)
In-Reply-To: <20220421173248.3asmhnqh6t26djyt@ubuntu.lan>
On 2022-04-21 13:33, Lancelot SIX via Gdb-patches wrote:
>> @@ -1158,8 +1159,8 @@ buildsym_compunit::augment_type_symtab ()
>> to the primary symtab. */
>> set_missing_symtab (m_global_symbols, cust);
>>
>> - mdict_add_pending (BLOCK_MULTIDICT (block),
>> - m_global_symbols);
>> + mdict_add_pending (block->multidict (),
>> + m_global_symbols);
>
> Hi, I just skimmed through and noticed that here tabs are replaced with
> spaces. (yes, my mail reader highlights this)
Hmm strange, thanks for pointing it out. This fits on a single line anyway.
Fixed locally.
Simon
next prev parent reply other threads:[~2022-04-21 17:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 14:58 [PATCH 01/14] gdb: remove BLOCK_{START,END} macros Simon Marchi
2022-04-21 14:58 ` [PATCH 02/14] gdb: remove BLOCK_FUNCTION macro Simon Marchi
2022-04-21 14:58 ` [PATCH 03/14] gdb: remove BLOCK_SUPERBLOCK macro Simon Marchi
2022-04-21 14:59 ` [PATCH 04/14] gdb: remove BLOCK_MULTIDICT macro Simon Marchi
2022-04-21 17:33 ` Lancelot SIX
2022-04-21 17:49 ` Simon Marchi [this message]
2022-04-21 14:59 ` [PATCH 05/14] gdb: remove BLOCK_NAMESPACE macro Simon Marchi
2022-04-21 14:59 ` [PATCH 06/14] gdb: remove BLOCK_RANGE_{START,END} macros Simon Marchi
2022-04-21 14:59 ` [PATCH 07/14] gdb: remove BLOCK_RANGES macro Simon Marchi
2022-04-21 18:16 ` Pedro Alves
2022-04-21 18:57 ` Simon Marchi
2022-04-28 10:47 ` Andrew Burgess
2022-04-21 14:59 ` [PATCH 08/14] gdb: remove BLOCK_NRANGES macro Simon Marchi
2022-04-21 17:38 ` Lancelot SIX
2022-04-21 17:52 ` Simon Marchi
2022-04-21 14:59 ` [PATCH 09/14] gdb: remove BLOCK_RANGE macro Simon Marchi
2022-04-21 14:59 ` [PATCH 10/14] gdb: remove BLOCK_CONTIGUOUS_P macro Simon Marchi
2022-04-21 18:16 ` Lancelot SIX
2022-04-21 18:59 ` Simon Marchi
2022-04-28 2:39 ` [PATCH 01/14] gdb: remove BLOCK_{START,END} macros Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb446d6e-87d4-89f8-3b4b-cd43b6aca429@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).