From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id A75E43838030
 for <gdb-patches@sourceware.org>; Thu, 21 Apr 2022 17:49:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A75E43838030
Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net
 [192.222.180.24])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id EC3111E01D;
 Thu, 21 Apr 2022 13:49:29 -0400 (EDT)
Message-ID: <fb446d6e-87d4-89f8-3b4b-cd43b6aca429@simark.ca>
Date: Thu, 21 Apr 2022 13:49:29 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 04/14] gdb: remove BLOCK_MULTIDICT macro
Content-Language: tl
To: Lancelot SIX <lsix@lancelotsix.com>,
 Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
References: <20220421145910.15335-1-simon.marchi@efficios.com>
 <20220421145910.15335-4-simon.marchi@efficios.com>
 <20220421173248.3asmhnqh6t26djyt@ubuntu.lan>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <20220421173248.3asmhnqh6t26djyt@ubuntu.lan>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2022 17:49:31 -0000

On 2022-04-21 13:33, Lancelot SIX via Gdb-patches wrote:
>> @@ -1158,8 +1159,8 @@ buildsym_compunit::augment_type_symtab ()
>>  	 to the primary symtab.  */
>>        set_missing_symtab (m_global_symbols, cust);
>>  
>> -      mdict_add_pending (BLOCK_MULTIDICT (block),
>> -			m_global_symbols);
>> +      mdict_add_pending (block->multidict (),
>> +                         m_global_symbols);
> 
> Hi, I just skimmed through and noticed that here tabs are replaced with
> spaces.  (yes, my mail reader highlights this)

Hmm strange, thanks for pointing it out.  This fits on a single line anyway.

Fixed locally.

Simon