From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nx126.node01.secure-mailgate.com (nx126.node01.secure-mailgate.com [89.22.108.126]) by sourceware.org (Postfix) with ESMTPS id E7CA33858D20 for ; Thu, 25 Apr 2024 19:37:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7CA33858D20 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7CA33858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.22.108.126 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714073843; cv=none; b=Rv9wdkVgF3ljquMn/Ed6qQNc968tsS0k2cji/GqPGWaEISrC6NC9/Sgz6qADrKol3CYYuBv4XlM+yKlPBPZzh3u4dNna+nmfuOaj6jLn9KLAwjCx2ZKrqPjqXfnE3OrF3CarVMeFeUZ4+oxc2uyJ63+yXV/U4W3d07efUTknRv4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714073843; c=relaxed/simple; bh=72NQq4Rp5Y/cpgN/sJhZVS1bqyn7TZ9mpXLQtwNZOmQ=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=YFmZNPRTl/bnJhZW/TO1dsBgYIJLV+Txp16HdON05CpF3mw1MRt7NZOviijUraI2bCL3XJqIknoAoAKiR8K+i5k8TO74eRawZfe9O+Uk2REJ2HWiUvXa7E2N9+OL96AHuQGFoM3TrWb7CvQP20TrPkcDyYM+QGEUJSzXG49sTQY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from web73.alfahosting-server.de ([5.44.111.53]) by node01.secure-mailgate.com with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1s04uD-0004rR-IG; Thu, 25 Apr 2024 21:37:19 +0200 X-SecureMailgate-Identity: web24339892p2;web73.alfahosting-server.de Received: from proxy01.mail.wum.dogado.net (proxy01.mail.wum.dogado.net [5.44.111.201]) (Authenticated sender: web24339892p2) by web73.alfahosting-server.de (Postfix) with ESMTPSA id 244A0287970; Thu, 25 Apr 2024 21:37:16 +0200 (CEST) X-SecureMailgate-Identity: web24339892p2;web73.alfahosting-server.de Message-ID: Date: Thu, 25 Apr 2024 21:39:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] gdb/testsuite: Add libc_has_debug_info require helper To: Thiago Jung Bauermann , "gdb-patches@sourceware.org" References: <20240422230700.1173173-1-thiago.bauermann@linaro.org> <20240422230700.1173173-2-thiago.bauermann@linaro.org> <20240423100947.3d5692be@f39-zbm-amd> <87h6fq3ezg.fsf@linaro.org> Content-Language: en-US From: Bernd Edlinger In-Reply-To: <87h6fq3ezg.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-PPP-Message-ID: <171407383678.3873174.994931839212755892@web73.alfahosting-server.de> X-PPP-Vhost: edlinger-online.de X-Originating-IP: 5.44.111.53 X-SecureMailgate-Domain: web73.alfahosting-server.de X-SecureMailgate-Username: 5.44.111.53 Authentication-Results: secure-mailgate.com; auth=pass smtp.auth=5.44.111.53@web73.alfahosting-server.de X-SecureMailgate-Outgoing-Class: ham X-SecureMailgate-Outgoing-Evidence: Combined (0.10) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT9BaMe1a1IoCsOoTBiT0bRlPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wQ2WWhGxHCRluE0ME/T5Udfv0ubmOcHFajiPDMlw6OUFyy uLviva0n8P+eUu23ZcPag9mpVLmLQo0w21UKLS1HSFrMwbY4cRFPXLNpRfrn5YL05zdbiGoQQf+t JJZXnwr6thm+7tQQmJTezbtWAoc7cQ39KXobcQeAYFYwvP52IO5+H2xU/aiLxehfuWVH0OBVhwAD ydg91UfjAJlfTy3KXuzhm+WdMyHskvQ9DB4gmC/HCXIkDlUfwGqJ+Sz2tI5Apn/ouZ/JEWwZ+oEq HiQu2bubfKbW3NXliNOj/S0uTD0xcs1sQlfpeU+iabP52PAML5i3g2GFaGQnZ3KowlU8anvoc7s0 eHtsyrH7f4vWswFFjNNtrAj/Okiz9Upqi24ERi8IumEER73pAk6XXsDqbN87qJveuvI4FkaTzox5 7b56rW/RDMTEEOCZ+gp9dmKA3IULGkvKvDsUh63xKgXs45aT5XP7ls89z4vumDFXuLJ8TXdxxpl8 Kml3XyIcbRg/wTTPPNd86IKTnRkQBnELtZ/mmPaMqL8vA/zkVXOTRQswr0cL6lRAEDJHTf5jN3xI cZHHKCALzxe3ovtYIZ77uQ5pag4gtliWH2q+i7nZTCRvLr8h9B3YCK/VuigaD5itI4g+l6rCWbY0 MZcgnbHs8Di32d0B2108h2Wj7PmPl5bGKkmrKy71ZNGokIJ6cJy2BB2WwDMO2dh6aYOcqXkH2Mz1 hUcpV3tHVdpYu3gehQJa3IhbtoPG/hU+hVEm8u33fAZIQUeMKaTZ27Hy3NJMBvsQ8jEPAUffmsrH LkoUE3WfPwR5SINWVSMZp/52PQ4ou4dYd4xUqg9uTvh5tZa/Mi/D4LFZHdqd1sOYjaKi/oleeH66 PiXzLQpxQ2e0eIYhu1/rdU1t/SWu+yxj6TsAqeGBxBLlYP99vhc/EIxqXFhd7+Z3ohEuqbhw2IGi K9BnIcHHlZfE9DkHvQAgtajybnUSpXtoeaeIbEKC07FSHGmw9NR4AQazxtzM670FEZNzKLefV/le S7MPVqZMaRuLDNhzVfdYAWUP9T27PHqOuEzcJf4QyeB45bMoYMjx+B6F0yiKgJfR7sHiPl4Dogmv nPEqDBYD730ufVwLkhC7P68zJ25JHkf2y1fH38x/opU= X-Report-Abuse-To: spam@node04.secure-mailgate.com X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_DMARC_NONE,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Thiago, On 4/24/24 18:25, Thiago Jung Bauermann wrote: > > Hello Kevin, > > Kevin Buettner writes: > >> On Mon, 22 Apr 2024 20:06:59 -0300 >> Thiago Jung Bauermann wrote: >> >>> Factor the test for libc debug info out of gdb.base/relativedebug.exp to >>> a new procedure. >>> >>> Also, change the "info sharedlibrary" test to explicitly detect when >>> libc has debug info. >>> --- >>> >>> As mentioned in the cover letter, the new testcase doesn't use this helper >>> procedure anymore so this is an optional patch. I think it's a nice >>> cleanup, though I didn't find any other testcase that need it so perhaps >>> the new helper is not as useful as I imagine it to be. I'm fine with not >>> committing this patch. >>> >>> Changes in v3: >>> - Include in test program to avoid error when using clang >>> (suggested by Kevin). >> >> I agree that it's a nice cleanup and I think that it should go in. >> >> I've retested with CC_FOR_TARGET set to clang and also gcc. It works >> for both. >> >> Approved-by: Kevin Buettner > > Thank you! Pushed as commit f5ef12c3f1af. > I think I have an issue with this commmit. I use a self-built riscv-unknown-elf toolchain with newlib, so there is no libc at all, regardless of debug info. since today, I see messages like: Running /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp ... FAIL: gdb.base/relativedebug.exp: info sharedlibrary libc.so ERROR: tcl error sourcing /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp. ERROR: tcl error code TCL READ VARNAME ERROR: can't read "libc_has_debug_info": no such variable while executing "verbose "$me: returning $libc_has_debug_info" 2" (procedure "gdb_real__libc_has_debug_info" line 47) invoked from within "gdb_real__libc_has_debug_info" ("uplevel" body line 1) invoked from within "uplevel 2 [list $real_name {*}$args]" invoked from within "gdb_do_cache_wrap $real_name {*}$args" (procedure "gdb_do_cache" line 48) invoked from within "gdb_do_cache libc_has_debug_info" (procedure "libc_has_debug_info" line 1) invoked from within "libc_has_debug_info" ("uplevel" body line 1) invoked from within "uplevel 1 $fn" (procedure "require" line 11) invoked from within "require {!target_info exists gdb,nosignals} libc_has_debug_info" (file "/home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp" line 16) invoked from within "source /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp" invoked from within "catch "uplevel #0 source $test_file_name" msg" UNRESOLVED: gdb.base/relativedebug.exp: testcase '/home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.exp' aborted due to Tcl error PATH: gdb.base/relativedebug.exp: testcase '/home/ed/gnu/ while previously that looked like: gdb compile failed, /home/ed/gnu/riscv64-unknown-elf/lib/gcc/riscv64-unknown-elf/14.0.1/../../../../riscv64-unknown-elf/bin/ld: /tmp/ccjr19GC.o: in function `main': /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.c:30:(.text+0x28): undefined reference to `alarm' /home/ed/gnu/riscv64-unknown-elf/lib/gcc/riscv64-unknown-elf/14.0.1/../../../../riscv64-unknown-elf/bin/ld: /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.c:31:(.text+0x30): undefined reference to `pause' /home/ed/gnu/riscv64-unknown-elf/lib/gcc/riscv64-unknown-elf/14.0.1/../../../../riscv64-unknown-elf/bin/ld: /home/ed/gnu/binutils-build-riscv64/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/relativedebug.c:31:(.text+0x38): undefined reference to `pause' collect2: error: ld returned 1 exit status UNTESTED: gdb.base/relativedebug.exp: failed to compile so not very noisy, newlib does apparently not have alarm, pause, sleep, and similar, but much easier to understand the output... Regards, Bernd.