From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 4/5] gdb/testsuite: resolve duplicate test name in gdb.cp/cplusfuncs.exp
Date: Wed, 17 Mar 2021 11:24:00 +0000 [thread overview]
Message-ID: <fb4bf925638874f623f6e5e3d74f9001384a7d40.1615980148.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <cover.1615980148.git.andrew.burgess@embecosm.com>
While resolving duplicate test names I spotted that a test in
gdb.cp/cplusfuncs.exp included an unescaped '[]'. In TCL square
brackets enclose expressions to evaluate, and so in this case, where
there is no enclosed expression, this just evaluates to the empty
string.
This clearly was not what the test intended, so in this commit I have
escaped the square brackets. This has extended the test coverage.
gdb/testsuite/ChangeLog:
* gdb.cp/cplusfuncs.exp (test_paddr_operator_functions): Escape
square brackets in test.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.cp/cplusfuncs.exp | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.cp/cplusfuncs.exp b/gdb/testsuite/gdb.cp/cplusfuncs.exp
index 8e24db5db0d..f1c2ff4907f 100644
--- a/gdb/testsuite/gdb.cp/cplusfuncs.exp
+++ b/gdb/testsuite/gdb.cp/cplusfuncs.exp
@@ -497,7 +497,7 @@ proc test_paddr_operator_functions {} {
" = .* $hex <foo::operator new\\\[\\\]\\(.*\\)(| static)>"
print_addr "foo::operator delete($dm_type_void_star)"
- print_addr "foo::operator delete[]($dm_type_void_star)"
+ print_addr "foo::operator delete\[\]($dm_type_void_star)"
print_addr "foo::operator int($dm_type_void)"
print_addr "foo::operator $dm_operator_char_star\($dm_type_void)"
--
2.25.4
next prev parent reply other threads:[~2021-03-17 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 11:23 [PATCH 0/5] Remove duplicate test names from gdb.cp/*.exp Andrew Burgess
2021-03-17 11:23 ` [PATCH 1/5] gdb/testsuite: remove duplicate test names for gdb.cp/nsusing.exp Andrew Burgess
2021-03-17 11:23 ` [PATCH 2/5] gdb/testsuite: remove duplicate test names from gdb.cp/gdb2384.exp Andrew Burgess
2021-03-17 11:23 ` [PATCH 3/5] gdb/testsuite: remove duplicate test from gdb.cp/maint.exp Andrew Burgess
2021-03-17 11:24 ` Andrew Burgess [this message]
2021-03-17 11:24 ` [PATCH 5/5] gdb/testsuite: resolve remaining duplicate test names in gdb.cp/*.exp Andrew Burgess
2021-03-26 15:03 ` [PATCH 0/5] Remove duplicate test names from gdb.cp/*.exp Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb4bf925638874f623f6e5e3d74f9001384a7d40.1615980148.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).