[ was: Re: [PATCH 2/3] [gdb/tui] Fix buglet in set_border_kind_item ]

On 5/8/23 16:10, Tom de Vries via Gdb-patches wrote:
> While factoring out set_border_kind_item I noticed a buglet:
> ...
>    struct tui_translate *entry = translate (key, dict);
> 
>    if (*lval != (chtype) entry->value)
>      {
>        *lval = (entry->value < 0) ? acs : entry->value;
> ...
> 
> When assigning the new value to *lval, an entry->value of -1 is taken into
> account, but not when comparing to the current value of *lval.
> 
> Fix this by introducing:
> ...
>    int val = (entry->value < 0) ? acs : entry->value;
> ...
> and using this in both comparison and assignment.
> 

I'm not sure if the enhancement "border-kind active-ascii" will make it, 
so I've ported this fix to trunk and committed.

Thanks,
- Tom