Re: [PATCH] [gdb/testsuite] Update xfail in gdb.threads/attach-many-short-lived-threads.exp

[Carl Love <cel@linux.ibm.com>]

Tom:

On 1/19/24 08:27, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> But since commit c6f7f9c80c3 ("Bail out of "attach" if a thread cannot be
> Tom> traced"), the warning has been changed into an error.
> 
> Tom> Fix the FAIL by updating the test-case to expect an error instead of a
> Tom> warning.
> 
> Thanks, this looks good to me.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

The patch fixes the issues on my Power 9 box running "Ubuntu 22.04.3 LTS.
  
However, the Power 10 box running Fedora Linux 38 (Server Edition) still reports a lot of errors. I see the errors in the daily build on the machine.  I can reproduce the failures when running the test by itself with:

make check RUNTESTFLAGS='GDB=/home/carll/bin/gdb gdb.threads/attach-many-short-lived-threads.exp '

Here is some of the output from gdb.log:

The program is not being run.
(gdb) file /home/carll/GDB/build-current/gdb/testsuite/outputs/gdb.threads/attach-many-short-lived-threads/attach-many-short-lived-threads
Reading symbols from /home/carll/GDB/build-current/gdb/testsuite/outputs/gdb.threads/attach-many-short-lived-threads/attach-many-short-lived-threads...
(gdb) builtin_spawn /home/carll/GDB/build-current/gdb/testsuite/outputs/gdb.threads/attach-many-short-lived-threads/attach-many-short-lived-threads
attach 3385832
Attaching to program: /home/carll/GDB/build-current/gdb/testsuite/outputs/gdb.threads/attach-many-short-lived-threads/attach-many-short-lived-threads, process 3385832
Cannot attach to lwp 3513884: Operation not permitted (1)
(gdb) XFAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 1: attach (EPERM)
attach 3385832
Attaching to program: /home/carll/GDB/build-current/gdb/testsuite/outputs/gdb.threads/attach-many-short-lived-threads/attach-many-short-lived-threads, process 3385832
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: attach (timeout)
info threads
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: no new threads (timeout)
set breakpoint always-inserted on
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: set breakpoint always-inserted on (timeout)
break break_fn
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: break break_fn (timeout)
continue
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: break at break_fn: 1 (timeout)
continue
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: break at break_fn: 2 (timeout)
continue
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: break at break_fn: 3 (timeout)
print again = 1
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: reset timer in the inferior (timeout)
print seconds_left
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: print seconds_left (timeout)
detach
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: detach (timeout)
set breakpoint always-inserted off
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: set breakpoint always-inserted off (timeout)
delete breakpoints
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 2: delete all breakpoints in delete_breakpoints (timeout)
ERROR: breakpoints not deleted
attach 3385832
UNRESOLVED: gdb.threads/attach-many-short-lived-threads.exp: iter 3: attach (timeout)
info threads
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 3: no new threads (timeout)
set breakpoint always-inserted on
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 3: set breakpoint always-inserted on (timeout)
break break_fn
FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 3: break break_fn (timeout)
continue

etc.

closing exp10
waiting for exp10
testcase /home/carll/GDB/build-current/gdb/testsuite/../../../binutils-gdb-current/gdb/testsuite/gdb.threads/attach-many-short-lived-threads.exp completed in 1910 seconds

                 === gdb Summary ===

# of expected passes            1
# of unexpected failures        98
# of expected failures          1
# of unresolved testcases       8



Not sure if the failures are specific to the Distro/OS or not.  But I will try testing on a Power 10 system with other distros and let you know.  Please let me know if you have any ideas on how to fix these errors on Power 10.

                         Carl