From: John Baldwin <jhb@FreeBSD.org>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb: rename rs6000-nat.c to rs6000-aix-nat.c
Date: Tue, 16 Nov 2021 09:02:52 -0800 [thread overview]
Message-ID: <fb8a5b25-7636-92c0-c831-d51318db65c6@FreeBSD.org> (raw)
In-Reply-To: <20211116030421.517475-1-simon.marchi@polymtl.ca>
On 11/15/21 7:04 PM, Simon Marchi via Gdb-patches wrote:
> This file seems to be AIX-specific, according to its contents and
> configure.nat. Rename it to rs6000-aix-nat.c, to make that clear (and
> to follow the convention).
I can't test either of the patches in this series, but they both look
ok to me via the eyeball test.
--
John Baldwin
next prev parent reply other threads:[~2021-11-16 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 3:04 Simon Marchi
2021-11-16 3:04 ` [PATCH 2/2] gdb: move AIX_TEXT_SEGMENT_BASE to rs6000-aix-tdep.c, remove rs6000-tdep.h Simon Marchi
2021-11-16 17:02 ` John Baldwin [this message]
2021-11-18 15:41 ` [PATCH 1/2] gdb: rename rs6000-nat.c to rs6000-aix-nat.c Tom Tromey
2021-11-18 16:32 ` Simon Marchi
2021-11-18 19:40 ` Ulrich Weigand
2021-11-18 21:36 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb8a5b25-7636-92c0-c831-d51318db65c6@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).