From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id A8A493840C0B for ; Sat, 13 Jun 2020 14:40:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A8A493840C0B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 368361E111; Sat, 13 Jun 2020 10:40:05 -0400 (EDT) Subject: Re: [PATCH 4/4] Change target_read_string API To: Tom Tromey , gdb-patches@sourceware.org References: <20200612215356.22145-1-tromey@adacore.com> <20200612215356.22145-5-tromey@adacore.com> From: Simon Marchi Message-ID: Date: Sat, 13 Jun 2020 10:40:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200612215356.22145-5-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2020 14:40:06 -0000 On 2020-06-12 5:53 p.m., Tom Tromey wrote: > diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c > index 19d1105ae95..6c0cffe4a42 100644 > --- a/gdb/solib-svr4.c > +++ b/gdb/solib-svr4.c > @@ -958,7 +958,6 @@ open_symbol_file_object (int from_tty) > { > CORE_ADDR lm, l_name; > gdb::unique_xmalloc_ptr filename; > - int errcode; > struct link_map_offsets *lmo = svr4_fetch_link_map_offsets (); > struct type *ptr_type = builtin_type (target_gdbarch ())->builtin_data_ptr; > int l_name_size = TYPE_LENGTH (ptr_type); > @@ -993,12 +992,11 @@ open_symbol_file_object (int from_tty) > return 0; /* No filename. */ > > /* Now fetch the filename from target memory. */ > - target_read_string (l_name, &filename, SO_NAME_MAX_PATH_SIZE - 1, &errcode); > + filename = target_read_string (l_name, SO_NAME_MAX_PATH_SIZE - 1); Declare `filename` here? There are a few more occurences of this in the patch that I would fix, since that actually results in less generated code. Simon