From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id 7082639524B0 for ; Tue, 19 May 2020 12:24:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7082639524B0 Received: by mail-qt1-x842.google.com with SMTP id m44so10871114qtm.8 for ; Tue, 19 May 2020 05:24:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fR/zSBNd8OKvWAMV9ulDVRLqoYuTsqPJJqkYvJAq6zg=; b=et2qTCpzIQwOgk/Ti+SMjH7YQekg4hpEgB1aacH9DnKZHo971+9rfbmiFgMOPZYx1a XdcA/cZZQp/8v7zokUvZ4g9S7pkysKls/fnalhtDqSUQBzT1+duJ9UVaZfA2CR4Pszlf uzeL17q9LEX2ajOHGmQpbOkDr/UtWs+NgorOIWuPVPVUBQpoHnCwNQbzS3qJSvrB2HWF ZAD4CJao12DxbQ0exJCQ6d9vhlhG9WiYoQ/47F2+vJKHWMEM/0JeOZzK8MA4WP/GkH2y mPw2aQNkQ4H1ud6LqinZsQMMGfQMLouTjs5f5eZ152LsYi8ei/a66OE6LviznYiDqWkr nX4g== X-Gm-Message-State: AOAM533C6QuS0eonQ+AmC2EeJdUzXhDh1BmmISgrWx14m2ulf+Lxx0YB nDUs0pdlS8ndsP+CfK+2F0A9bPVZPUE= X-Google-Smtp-Source: ABdhPJwrB4n9w+rZoDP82ouOBIb+bj1eNrPjhCYYMhRSONJCq2gteUZQOEL4V5BrXy9cUR8rHbk+XA== X-Received: by 2002:ac8:5184:: with SMTP id c4mr20997410qtn.356.1589891039595; Tue, 19 May 2020 05:23:59 -0700 (PDT) Received: from [192.168.0.185] ([179.185.145.12]) by smtp.gmail.com with ESMTPSA id j90sm5301962qte.33.2020.05.19.05.23.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 05:23:58 -0700 (PDT) Subject: Re: [PATCH 1/6] Add column information of dwarf to the symbol information To: Tom Tromey , Hannes Domani via Gdb-patches References: <20200516172632.4803-1-ssbssa@yahoo.de> <20200516172632.4803-2-ssbssa@yahoo.de> <87blmli5ej.fsf@tromey.com> From: Luis Machado Message-ID: Date: Tue, 19 May 2020 09:23:55 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87blmli5ej.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 12:24:01 -0000 On 5/18/20 1:17 PM, Tom Tromey wrote: > Hannes> void > Hannes> buildsym_compunit::record_line (struct subfile *subfile, int line, > Hannes> - CORE_ADDR pc, bool is_stmt) > Hannes> + CORE_ADDR pc, bool is_stmt, int column) > > I think putting the column parameter next to the line parameter would be > more idiomatic. > > Tom > Should we avoid passing line/column separately and, instead, pass down a struct containing both? They're part of the same high level information (the position in the source file). That would be cleaner IMO.