From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 79A213858CDA for ; Fri, 15 Sep 2023 00:59:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79A213858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 38F0xF5p024081 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Sep 2023 20:59:19 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 38F0xF5p024081 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1694739560; bh=/xJRwXa3suiXCa0ns5aBclPYw54wmc6gQiRL1h+VXQ8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mduAasr+WtlHKmZrnd11xRgljPDoyPmmU9z9Xmj+1vm1sMHG3Lxw4cKfAtrDDCASS LUjnnD1yxwVbafPwN7FQaHPHUCJu/yNn1IazRv8P4bR9KPLJ6U8dWQ9du6PtGjJPkj V+7Qa6QXx4X1An/8nDGgVvavLJOAiT2uIND3w8iM= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B86331E092; Thu, 14 Sep 2023 20:59:14 -0400 (EDT) Message-ID: Date: Thu, 14 Sep 2023 20:59:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Specialize std::hash for ptid_t To: Vaseeharan Vinayagamoorthy , Tom Tromey Cc: "gdb-patches@sourceware.org" References: <20230911144718.3425981-1-tromey@adacore.com> <99e5e4c7-9530-4eaa-8062-c13abb66b7b2@polymtl.ca> <878r9cllbs.fsf@tromey.com> <8d359fca-6e2a-406e-a99a-d9623cbd37be@polymtl.ca> <875y4ch7nc.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 15 Sep 2023 00:59:15 +0000 X-Spam-Status: No, score=-3031.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-09-14 18:34, Vaseeharan Vinayagamoorthy wrote: > Hello Tom, > > It does build ok with GCC 7.5. > Has the minimum required version for building GDB changed? > At least for GCC, the minimum requirement seems to be 4.8: https://gcc.gnu.org/install/prerequisites.html We have members of the community that need to support gcc 4.8, for instance: https://inbox.sourceware.org/gdb-patches/20220714082054.GA21481@delia.home/ So, Tom's patch LGTM (sorry for suggesting the other form, I didn't know old gccs didn't like it). Simons