public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Wei-min Pan <weimin.pan@oracle.com>, Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.base/siginfo-thread.exp: Increase timeout for 'gcore' command
Date: Thu, 16 Mar 2017 17:08:00 -0000	[thread overview]
Message-ID: <fc3924d7-e749-2b84-2c79-c1edc7dc1651@redhat.com> (raw)
In-Reply-To: <58CAB698.7040602@oracle.com>

On 03/16/2017 04:00 PM, Wei-min Pan wrote:
> Yao Qi wrote:

>> Did you see timeout fails in all gcore related tests?  gdb_gcore_cmd is
>> used in many places in gdb testsuite.  Did you investigate why it is so
>> slow to generate coredump in gdb?
>>
>>   
> No, only this test failed with timeout and did so consistently. The
> generated core file was fine.
> We suspect the slow disk performance was the culprit.

I agree with Yao, and I'm not convinced.  The generated core file is just
"8.6M" on my x86_64 Fedora 23 and the test runs in under 1s here.

$ time make check TESTS="*/siginfo-thread.exp"
...
real    0m0.781s
user    0m0.554s
sys     0m0.152s


What's the size of the core you get?  If you run the test manually,
do we notice any kind of slowness?

If you have a general slowness issue in your testing host, then
this should be affecting all gcore tests the same.  We have some
tests that generate big cores on purpose even.

Thanks,
Pedro Alves

  reply	other threads:[~2017-03-16 17:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-01  3:23 Weimin Pan
2017-03-16 14:45 ` Yao Qi
2017-03-16 16:00   ` Wei-min Pan
2017-03-16 17:08     ` Pedro Alves [this message]
2017-03-16 18:27       ` Wei-min Pan
2017-03-16 18:34         ` Pedro Alves
2017-03-16 19:10           ` Wei-min Pan
2017-03-16 19:21             ` Pedro Alves
2017-03-16 19:51               ` Wei-min Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc3924d7-e749-2b84-2c79-c1edc7dc1651@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=weimin.pan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).