From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 9DFA73858024 for ; Thu, 24 Feb 2022 19:02:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DFA73858024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 61BF67D815; Thu, 24 Feb 2022 19:02:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K4MjY24Tyz4TBt; Thu, 24 Feb 2022 19:02:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645729361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BK4tOTMVzhIpq5lQgUswuiZZzfU/3/7kx4OaJvxKdE4=; b=rXnFcB/rWj+C+5mxjpOb91lm0TaR36oLB2ubv/wRCKd9jLj1snBXCTo0pbTzM3Nm3t4QMv Xerky0AMpCnYVhHiXmFwWJlQX8bVTKTsrYxpphfcUJAsL22gXqbdaJ8h+XuH+rSBZbHQzJ gkVkJmB3NRPPNwLyuNbdYzFQ0x7eyCAjheCk5vKR7FpuqQIMXP/r4dfhqd4GrGLKHVITYz m9olvljMGPPPBCu2h7FZhP/0AGMaszLHx472mrf7ZmPC17/EUkKitZv5KAqzqpsBxXCP0A QrBA5pgI8FnxeZ4IQHLYbBVTjrIQUs0GH3oQZUQtV9T7rUlZoZe/8E7OXr1KJg== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id DACFCC76C; Thu, 24 Feb 2022 19:02:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Thu, 24 Feb 2022 11:02:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v5 06/15] do_target_wait_1: Clear TARGET_WNOHANG if the target isn't async. Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220121201631.63530-1-jhb@FreeBSD.org> <20220121201631.63530-7-jhb@FreeBSD.org> <2a4bc2e5-a7b9-a448-1988-75c53dd61c83@polymtl.ca> <8300cb6a-c0d7-a2b7-ee20-f6eabb1c7d82@polymtl.ca> <1c29b477-e34b-bab0-7430-b506a8de18c2@polymtl.ca> <05224eba-4da5-92e7-e4f4-4cb708f315c1@FreeBSD.org> <80dd9924-7c26-16dd-fccd-bc55deb42403@polymtl.ca> From: John Baldwin In-Reply-To: <80dd9924-7c26-16dd-fccd-bc55deb42403@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645729361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BK4tOTMVzhIpq5lQgUswuiZZzfU/3/7kx4OaJvxKdE4=; b=OXWg3ZSMc1Y9Zi7XO/oO51UpJwyr9P9Umlim/KiO1TN5+SRzuX28tOinS+lrdjmnMNt1yH LWNEg9KTSdRPaHlvdKe6slW5FJrLzheCVle4w7R6BkKcfbbCvaSE9dCxgpLC6ctGDmzOfI DrFiI3GKy31rc6Gv8YzuK7Y0STSCb2NSHcojwnoQSZ82k6eFumu/tFM+TzCFajd47t+gGq HHOOdx03TuyyKQVr3G4PtQxY0PluuANowkRY3iADTvx19iO/OkpZ3HfH2jQWhlOTm6CF6o JluwbqsmOta8j0ekGRKINArKdtCMoJHk9x1P2xfbIrwsRDVFI8SsihnatdQTZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645729361; a=rsa-sha256; cv=none; b=QAk3z/WyQy9+kTikMQoBlvB6Hedxh4HbZ0bB0tkOte6RCHQpEKp68baJ2WkgA+WBcdrILL uO4NmKiosZZQVGORLqCthkMdXuIVT9OEY498n4Jq1RGF/YJBPz+a4Oo9RVpC/dgoNwS71m pF77eZBca/6Jl1+eKfPeurzfxQvjJN3bo8DrsPPIrmlAzqi27J5MOv9gpbbVZabGZ2/V+w DzSr7k1JB5bZn+bnOmiqy7Lmvmf4Ln9KpO3Ye1DTwXTLsWgcCX0DkS9tKP6q2BurtUY6vx 09s/IutMGHqVGcKciOPuVuB1XEiGvDa7Xm9gOqb8iQ0IFTO4jG6jMyy5lnlyHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 19:02:45 -0000 On 2/23/22 6:46 PM, Simon Marchi wrote: >> Thanks for digging the details up. I assumed it had something to do with >> an initial misunderstanding I had which was that a target was always in >> async mode vs only being in async mode when there are non-stopped >> inferiors. Can you please include these details in your commit reverting >> this change? (Or did you want me to push the revert? I'm happy for you >> to do so since you did the testing and investigation.) > > I'm not sure I understand what you want me to add. Here's what I came > up with, if you have suggestions of anything to add, let me know. This looks good to me. Thanks! -- John Baldwin