From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id F0AD33858D39 for ; Mon, 6 Mar 2023 17:59:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0AD33858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0EDA21E0D3; Mon, 6 Mar 2023 12:59:01 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1678125542; bh=JZbNNCvp7IfZGJMnJ5d1MV20+dagjaSP+HUpb6pmGOA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=qyB2lig0eywTq4jKrXVFe6YGFBl5hv0uzhN6N0gAaoTz5IhbM/MShP5mrbI5A9Ibg GUHUsKMSOu8OONjBT9Igzyse4GrrpLtp8Vf1EWOLqDPal6BCyzlWey0MXokZMLfBml PAZdeauc+BR2T3BPTC4uXER6eh9Nib7u/4/gUXpo= Message-ID: Date: Mon, 6 Mar 2023 12:59:00 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] Ensure index cache entry written in test Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230306164553.1449009-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20230306164553.1449009-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp > index 0614d4ee2db..7fdf90c2c24 100644 > --- a/gdb/testsuite/gdb.base/index-cache.exp > +++ b/gdb/testsuite/gdb.base/index-cache.exp > @@ -159,6 +159,8 @@ proc_with_prefix test_cache_enabled_miss { cache_dir } { > > run_test_with_flags $cache_dir on { > > + gdb_test_no_output "maintenance wait-for-index-cache" I would perhaps put this command in the run_test_with_flags proc, so that it applies to other tests as well. It shouldn't be necessary for those tests, but if there's a bug somewhere, it would make it reproduce more reliably. Otherwise: Approved-By: Simon Marchi Simon