Re: [PATCH 1/4] Rename objfile::sections

[Keith Seitz <keiths@redhat.com>]

On 4/16/23 09:28, Tom Tromey wrote:
> I think objfile::sections makes sense as the name of the method to
> iterate over an objfile's sections, so this patch renames the existing
> field to objfile::sections_start in preparation for that.

I rather like this rename, tbh, because the related member is named
"sections_end". I like symmetry. :-)

Just one little comment...

> diff --git a/gdb/objfiles.h b/gdb/objfiles.h
> index 342aa09ac6a..0e326287907 100644
> --- a/gdb/objfiles.h
> +++ b/gdb/objfiles.h
> @@ -128,7 +128,7 @@ struct entry_info
>   };
>   
>   #define ALL_OBJFILE_OSECTIONS(objfile, osect)	\
> -  for (osect = objfile->sections; osect < objfile->sections_end; osect++) \
> +  for (osect = objfile->sections_start; osect < objfile->sections_end; osect++) \
>       if (osect->the_bfd_section == NULL)					\
>         {									\
>   	/* Nothing.  */							\
> @@ -722,7 +722,7 @@ struct objfile
>        structure data is only valid for certain sections
>        (e.g. non-empty, SEC_ALLOC).  */
> 

... about a comment!

The paragraph/comment here needs updating, I think:

    "SECTIONS points to the first entry in the table, [...]"

Keith

> -  struct obj_section *sections = nullptr;
> +  struct obj_section *sections_start = nullptr;
>     struct obj_section *sections_end = nullptr;
>   
>     /* GDB allows to have debug symbols in separate object files.  This is