Re: [PATCH] Please define thread_info as struct thread_info (and other stuff)

[Svante Signell <svante.signell@gmail.com>]

On Mon, 2018-12-17 at 21:51 +0100, Svante Signell wrote:
> On Sun, 2018-12-16 at 16:10 -0700, Tom Tromey wrote:

> > Svante> Finally, I've found the problem (but no workaround yet):
> > thread_info is an RPC on GNU/Hurd, and including mach.h in
> > gdb/config/i386/nm-i386gnu.h:#include <mach.h> further includes
> > <mach/mach_interface.h> which has the conflicting name of that RPC:
> > kern_return_t thread_info
> > 
> > Typical answers for this kind of thing are either to segregate the
> > use of the system header somehow, or maybe namespacing or some
> > other kind of renaming. I haven't looked into the details much in
> > this case I'm afraid.
> 
> As I see it you need to:
> 
> 1) Apply the patches submitted earlier in this thread using struct
> thread_info
> consistently everywhere (simplest).
> 2) Rename all usage of the struct thread_info to something else e.g.
> struct gdb_thread_info (not future-proof though).
> 3) Create a gdb namespace for all your code to avoid conflicts.
> 4) Segregate the use of system header files as you write above. Dunno
> how to do that though, but some of you should.

Hi again. Seem like I did not get the reply from John Baldwin on this
thread, some gmail issue? Can somebody forward it to me, I've only seen
it on the mailing list archives: https://sourceware.org/ml/gdb-patches/
2018-12/msg00202.html

Seems like nothing is happening so far. Did you expect me to take
action on this issue? Or is this a low-prio problem for you, Hurd being
a second class citizen?