[PATCH] Fix gdb.mi/mi-breakpoint-changed.exp for remote targets

[PATCH] Fix gdb.mi/mi-breakpoint-changed.exp for remote targets

[Simon Marchi]

The libraries are never downloaded to the target for the first test
(test_insert_delete_modify), so the executable can't run properly.

I also added some with_test_prefix to help differentiate between the
different test case phases.

gdb/testsuite/ChangeLog:

	* gdb.mi/mi-breakpoint-changed.exp: Add some with_test_prefix.
	(test_insert_delete_modify): Call mi_load_shlibs before trying to
	run.
---
 gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
index c12f8b8..cda8c4a 100644
--- a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
+++ b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp
@@ -45,12 +45,15 @@ if { [gdb_compile $srcdir/$subdir/$srcfile $binfile executable $exec_opts] != ""
 
 proc test_insert_delete_modify { } {
     global mi_gdb_prompt
+    global lib_sl1 lib_sl2
 
     gdb_exit
     if [mi_gdb_start] {
 	continue
     }
 
+    mi_load_shlibs $lib_sl1 $lib_sl2
+
     mi_run_to_main
 
     mi_gdb_test "break marker" \
@@ -150,7 +153,9 @@ proc test_insert_delete_modify { } {
     }
 }
 
-test_insert_delete_modify
+with_test_prefix "test_insert_delete_modify" {
+    test_insert_delete_modify
+}
 
 # Test 'breakpoint-modified' notification is emited when pending breakpoints are
 # resolved.
@@ -251,4 +256,6 @@ proc test_pending_resolved { } {
     }
 }
 
-test_pending_resolved
+with_test_prefix "test_pending_resolved" {
+    test_pending_resolved
+}
-- 
2.8.0

Re: [PATCH] Fix gdb.mi/mi-breakpoint-changed.exp for remote targets

[Yao Qi]

Simon Marchi <simon.marchi@polymtl.ca> writes:

> gdb/testsuite/ChangeLog:
>
> 	* gdb.mi/mi-breakpoint-changed.exp: Add some with_test_prefix.
> 	(test_insert_delete_modify): Call mi_load_shlibs before trying to
> 	run.

Patch is fine to me.

-- 
Yao (齐尧)

Re: [PATCH] Fix gdb.mi/mi-breakpoint-changed.exp for remote targets

[Simon Marchi]

On 2016-04-04 05:23, Yao Qi wrote:
> Patch is fine to me.

Thanks, pushed.