From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74754 invoked by alias); 29 Jun 2018 14:51:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73776 invoked by uid 89); 29 Jun 2018 14:51:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Attaching X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Jun 2018 14:51:03 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 619CD406EA4F; Fri, 29 Jun 2018 14:51:02 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA3C42156880; Fri, 29 Jun 2018 14:51:01 +0000 (UTC) Subject: Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach To: Richard Bunt , gdb-patches@sourceware.org References: Cc: nd@arm.com From: Pedro Alves Message-ID: Date: Fri, 29 Jun 2018 14:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00720.txt.bz2 Hi, On 06/27/2018 11:17 AM, Richard Bunt wrote: > --- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp > +++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp > @@ -57,12 +57,12 @@ clean_restart $binfile > > gdb_test "attach $testpid" "Attaching to program: .*, process $testpid.*" Diffing test results, I noticed: PASS: gdb.base/watchpoint-hw-attach.exp: continue to breakpoint: pidacquired PASS: gdb.base/watchpoint-hw-attach.exp: get integer valueof "mypid" PASS: gdb.base/watchpoint-hw-attach.exp: detach PASS: gdb.base/watchpoint-hw-attach.exp: attach 25501 ^^^^^ It's better to avoid using unstable numbers in test names. Can you fix this in the obvious way (make it print "attach" only)? Thanks. Thanks, Pedro Alves