From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 85F333972698 for ; Thu, 8 Dec 2022 20:57:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 85F333972698 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2B8KvL95012858 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Dec 2022 15:57:25 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2B8KvL95012858 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1670533046; bh=hcgdc+h9JXBkLl20tBcAzp03EVhMscVvH4+2AMPxT/Q=; h=Date:Subject:To:References:From:In-Reply-To:From; b=axzRuk1CqhRgsaw/nD0mn7Z5yT7nVpXDB7cY2drM+jWYd+hKhfL7Lddj41Ohh2qqT pW6tHRg6Q8ihXZyu+cxWW6fPTA92Kbo/aIMSPYVAaNuuAZtzhKDoYz0ZkC9wQ5DiJ5 fwWM1TOukuSj9GchVm2Wr9xvsJr0YeGEn6pFO1h0= Received: from [132.207.214.75] (Sansfil-Eduroam-Externe-214-75.polymtl.ca [132.207.214.75]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 04BC91E0CB; Thu, 8 Dec 2022 15:57:20 -0500 (EST) Message-ID: Date: Thu, 8 Dec 2022 15:57:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 5/6] gdb: make frame_info_ptr grab frame level and id on construction Content-Language: fr To: Bruno Larsen , gdb-patches@sourceware.org References: <20221202180052.212745-1-simon.marchi@polymtl.ca> <20221202180052.212745-6-simon.marchi@polymtl.ca> <91de9931-4031-42b2-c441-87e1c30b20ee@redhat.com> From: Simon Marchi In-Reply-To: <91de9931-4031-42b2-c441-87e1c30b20ee@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 8 Dec 2022 20:57:21 +0000 X-Spam-Status: No, score=-3031.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/8/22 03:51, Bruno Larsen wrote: > On 02/12/2022 19:00, Simon Marchi via Gdb-patches wrote: >> This is the first step of making frame_info_ptr automatic.  Remove the >> frame_info_ptr::prepare_reinflate method, move that code to the >> constructor. > > I'm still trying to review the rest of the series, but this patch looks pretty simple, and I'm happy that you managed to do what I wanted but couldn't. > > Reviewed-By: Bruno Larsen Thanks, this patch will change in v2, but not much, so I'll put your RB right away. Simon