From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D59B33858D33 for ; Wed, 15 Feb 2023 12:22:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D59B33858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676463743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OZnp+lR1YYedtkNxRK4P+S/A1SC7crs9ozblRqIpgZE=; b=b/H1me76Nrgo6yYER4wZ+IGYq/zC+jeXoymsrupWmmXR4cKUFl24WEuH5F0Y1noqdxG72P 9zWCCbmDUr/vsDQYQd0PB8L/Gdj/9YLbeWHsxKxPKf/nU9RbA0NM1Xi3Dpo66byQzipfNQ 9c1m3YrlzYgU5nIwMORKRZDeDt9vUAg= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-479-huqX5KIyMAaZx-bDj8SgSA-1; Wed, 15 Feb 2023 07:22:22 -0500 X-MC-Unique: huqX5KIyMAaZx-bDj8SgSA-1 Received: by mail-qk1-f199.google.com with SMTP id x14-20020a05620a14ae00b0072f7f0f356bso11284197qkj.1 for ; Wed, 15 Feb 2023 04:22:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OZnp+lR1YYedtkNxRK4P+S/A1SC7crs9ozblRqIpgZE=; b=doxvRGDeo05T4lEObDyHI3RHjruY9pG8Ud30p6zpFXINDngHrYXK5R/+u917GY5D3Y jwy+Ib199pXrGQdG2mcR9I7lfDxd2r+IA4zebadgqoFnaT2PudChJpxmOGC4AKOld6wH wQl5s+r3cbNahiDpoPyxsX+xW7XLGtw/z0dqKMqvQfrFt4UlyxthGD0LzumvcuF4q/XE PVUQtfPAM2agi0AyBynRksliohGZw20uynxF9s/pV70qMM07sX4lyidqQ1RsronLrg35 Uw/2rLILUUYq6kqqxWyX9j/WRAUD7T9nTOwuwPpxQHi2iLCE30g8W3yYU7V8TpI5d9im xHBQ== X-Gm-Message-State: AO0yUKUDFPsshuJ0bU14Y2PKu/J5ub3y6EKAqf+rBADt/fB5a7V5JNJ8 HqoHHpHbmKVoIHHSBwrG+3JLDUmfodMrUSWI3+6aEoB7xq3/r6roK49PNnt8IdsDdJrIDmHutaW LErDV8198Ybs8CPwVffZenQ== X-Received: by 2002:ac8:5c54:0:b0:3bb:8dfd:c867 with SMTP id j20-20020ac85c54000000b003bb8dfdc867mr2950616qtj.24.1676463741632; Wed, 15 Feb 2023 04:22:21 -0800 (PST) X-Google-Smtp-Source: AK7set/LyzZ4ba/5yR9VRqeTVbopk+LDRCxwxG7Ww1xEWUEEXxv6W/f9TicaYYfxS0G2S3K7adDf4w== X-Received: by 2002:ac8:5c54:0:b0:3bb:8dfd:c867 with SMTP id j20-20020ac85c54000000b003bb8dfdc867mr2950600qtj.24.1676463741414; Wed, 15 Feb 2023 04:22:21 -0800 (PST) Received: from [192.168.0.45] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id a7-20020ac86107000000b003ba11bfe4fcsm13061741qtm.28.2023.02.15.04.22.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 04:22:21 -0800 (PST) Message-ID: Date: Wed, 15 Feb 2023 13:22:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 0/6] Use bool in value To: Tom Tromey , gdb-patches@sourceware.org References: <20230214-submit-more-value-stuff-v1-0-2fb85efbaa72@tromey.com> From: Bruno Larsen In-Reply-To: <20230214-submit-more-value-stuff-v1-0-2fb85efbaa72@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/02/2023 21:23, Tom Tromey wrote: > There are a few spots in struct value that should use 'bool'. This > short series fixes these up. > > Regression tested on x86-64 Fedora 36. > > --- > Tom Tromey (6): > Change value::m_modifiable to bool > Change value::m_lazy to bool > Change value::m_initialized to bool > Change value::m_stack to bool > Have value::bits_synthetic_pointer return bool > Return bool from more value methods > > gdb/breakpoint.c | 3 +-- > gdb/dwarf2/expr.c | 12 ++++----- > gdb/dwarf2/expr.h | 6 ++--- > gdb/dwarf2/loc.c | 2 +- > gdb/frame-unwind.c | 2 +- > gdb/gnu-v2-abi.c | 2 +- > gdb/opencl-lang.c | 10 ++++---- > gdb/ppc-linux-nat.c | 2 +- > gdb/valops.c | 4 +-- > gdb/valprint.c | 2 +- > gdb/value.c | 48 +++++++++++++++++------------------ > gdb/value.h | 72 ++++++++++++++++++++++++++--------------------------- > 12 files changed, 82 insertions(+), 83 deletions(-) > --- > base-commit: 5bed9dc992a0136d403a7addb29a2ed822fd4fd2 > change-id: 20230214-submit-more-value-stuff-dea23b091773 > > Best regards, I've double checked the testing and changes, and apart from a comment on patch #2 everything looks ready to go. You may apply my tag to the whole series: Reviewed-By: Bruno Larsen -- Cheers, Bruno