Re: [PATCH] Update gdb to black 22.6.0

[Simon Marchi <simark@simark.ca>]

On 2022-07-14 14:41, Tom Tromey via Gdb-patches wrote:
> I couldn't get black 21.12b0 to work correctly -- it always errored,
> even with just "--version" -- so instead I make a virtualenv with the
> latest release.  Running it on gdb yielded two minor changes.
> ---
>  gdb/python/lib/gdb/__init__.py             | 7 ++++---
>  gdb/testsuite/gdb.python/py-send-packet.py | 6 ++++--
>  2 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/gdb/python/lib/gdb/__init__.py b/gdb/python/lib/gdb/__init__.py
> index 9e9978ef30e..5b10e3e2381 100644
> --- a/gdb/python/lib/gdb/__init__.py
> +++ b/gdb/python/lib/gdb/__init__.py
> @@ -30,7 +30,8 @@ from _gdb import *
>  # Historically, gdb.events was always available, so ensure it's
>  # still available without an explicit import.
>  import _gdbevents as events
> -sys.modules['gdb.events'] = events
> +
> +sys.modules["gdb.events"] = events
>  
>  
>  class _GdbFile(object):
> @@ -243,9 +244,9 @@ def set_parameter(name, value):
>      # can return them, but they can't be passed to 'set' this way.
>      if isinstance(value, bool):
>          if value:
> -            value = 'on'
> +            value = "on"
>          else:
> -            value = 'off'
> +            value = "off"
>      execute("set " + name + " " + str(value), to_string=True)
>  
>  
> diff --git a/gdb/testsuite/gdb.python/py-send-packet.py b/gdb/testsuite/gdb.python/py-send-packet.py
> index ae70b852538..26deeb1e40d 100644
> --- a/gdb/testsuite/gdb.python/py-send-packet.py
> +++ b/gdb/testsuite/gdb.python/py-send-packet.py
> @@ -114,10 +114,12 @@ def check_global_var(expected_val):
>      if val != expected_val:
>          raise gdb.GdbError("global_var is 0x%x, expected 0x%x" % (val, expected_val))
>  
> +
>  # Return a bytes object representing an 'X' packet header with
>  # address ADDR.
> -def xpacket_header (addr):
> -    return ("X%x,4:" % addr).encode('ascii')
> +def xpacket_header(addr):
> +    return ("X%x,4:" % addr).encode("ascii")
> +
>  
>  # Set the 'X' packet to the remote target to set a global variable.
>  # Checks that we can send byte values.

FWIW, these changes are not related to using a new black version, they
are cases of people not running black in previous patches.  I am able to
run black 21.12.b0, and it yields the exact same changes.

Note that in the wiki, I wrote "Use the latest available black
version", the goal is not to pin a version.  If you notice some changes
when running the latest version of black, just push a trivial patch.

Simon